Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hightrust.id #60

Merged
merged 1 commit into from
Apr 20, 2024
Merged

added hightrust.id #60

merged 1 commit into from
Apr 20, 2024

Conversation

akolio
Copy link
Contributor

@akolio akolio commented Apr 19, 2024

No description provided.

@cre8
Copy link
Contributor

cre8 commented Apr 19, 2024

Hi @akolio,

are you able to sign your commit so the DCO check can pass? Then we are able to merge your PR :)

Signed-off-by: Antti Köliö <[email protected]>
@akolio
Copy link
Contributor Author

akolio commented Apr 20, 2024

Thanks @cre8!
Luckily GitHub had straightforward steps to add the signoff.

@cre8 cre8 merged commit c47aba0 into openwallet-foundation:main Apr 20, 2024
4 checks passed
@samuelmr
Copy link
Contributor

I'm not opposed to adding Hightrust.id, but wondering why the entry is basically blank.

@akolio, is there a reason you didn't provide more information? If you're affiliated with Hightrust, it should be relatively easy for you to find out information about supported credential formats, signature algorithms, etc.

At least the urlWebsite would be nice (it's mandatory in the schema) so that the audience has a pointer on where to look for more information.

@cre8, I think we shouldn't accept blank entries. They provide very little value to the audience. I removed many entries from the previous iteration due to missing data.

@akolio
Copy link
Contributor Author

akolio commented Apr 21, 2024

We were planning on adding fields as we go. Company URL was added as CompanyUrl which is what the "add wallet" tool on https://openwallet-foundation.github.io/digital-wallet-and-agent-overviews-sig/ wanted. But I see it might be deprecated.

I noticed there were other differences in this json too compared to the ones on GitHub. E.g. there's no "linkToApp" (instead there are fields such as "urlAppStore", "urlGooglePlayStore" and "urlWebsite").
The add wallet tool might need a little refreshing 🙂

@samuelmr
Copy link
Contributor

Thanks!

@cre8, will you check that the attributes in the add component correspond to the schema?

@cre8
Copy link
Contributor

cre8 commented Apr 21, 2024

@samuelmr I commented the check out since we had the old schemas included, see: https://github.com/openwallet-foundation/digital-wallet-and-agent-overviews-sig/blob/main/.github/workflows/main.yml#L41

I will add it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants