Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migration to new approach #26

Merged
merged 79 commits into from
Mar 9, 2024
Merged

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Feb 23, 2024

This PR has multiple breaking changes:

  • visualization via an angular application.
  • splitting up wallet objects into separate files (these files have still included their old values and were not tidied up)
  • CICD: for publishing and also validating the entries (validation is commented out for how since the old entries are not migrated in the final way)

This PR is for thenext branch where we can discuss other changes and migrate wallets until we are fine this the result. Tasks can be splitted up in different PRs to not overload this PR.

After we have finished the migration, we can make a PR to the main branch

maaikevanleuken and others added 29 commits February 23, 2024 11:08
* Update script.js fixing names

Signed-off-by: Maaike van Leuken <[email protected]>

* Update index.html

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
cre8 and others added 13 commits March 8, 2024 08:45
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
)

* adding the stylesheet

Signed-off-by: Maaike van Leuken <[email protected]>

* added slides of previous meetings

Signed-off-by: Maaike van Leuken <[email protected]>

* Update README.md

Added motivation for contributors

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Maaike van Leuken <[email protected]>
remove randomised entries in overview, based on issue openwallet-foundation#40

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
@samuelmr samuelmr merged commit 803924d into openwallet-foundation:next Mar 9, 2024
4 checks passed
@cre8 cre8 deleted the angular branch March 9, 2024 11:28
@cre8 cre8 restored the angular branch March 15, 2024 14:58
@cre8 cre8 deleted the angular branch March 15, 2024 15:02
cre8 added a commit that referenced this pull request Apr 7, 2024
* Maaikevanleuken patch 7 (#20)

* Update script.js fixing names

Signed-off-by: Maaike van Leuken <[email protected]>

* Update index.html

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* replace application with angular, restructure wallet data

Signed-off-by: Mirko Mollik <[email protected]>

* let the ci also run on the angular branch for test purposes

Signed-off-by: Mirko Mollik <[email protected]>

* update ci jobs

Signed-off-by: Mirko Mollik <[email protected]>

* fix ci errors

Signed-off-by: Mirko Mollik <[email protected]>

* set correct version for upload artifact

Signed-off-by: Mirko Mollik <[email protected]>

* fix dist path

Signed-off-by: Mirko Mollik <[email protected]>

* increase build warnings

Signed-off-by: Mirko Mollik <[email protected]>

* set correct basehref

Signed-off-by: Mirko Mollik <[email protected]>

* remove angular icon

Signed-off-by: Mirko Mollik <[email protected]>

* set correct fetch path

Signed-off-by: Mirko Mollik <[email protected]>

* add some comments

Signed-off-by: Mirko Mollik <[email protected]>

* add info panel

Signed-off-by: Mirko Mollik <[email protected]>

* include show page for wallets

Signed-off-by: Mirko Mollik <[email protected]>

* update info

Signed-off-by: Mirko Mollik <[email protected]>

* outcomment migration job

Signed-off-by: Mirko Mollik <[email protected]>

* make contact button optional

Signed-off-by: Mirko Mollik <[email protected]>

* add dummy for credential formats

Signed-off-by: Mirko Mollik <[email protected]>

* add all entries for sig linking

Signed-off-by: Mirko Mollik <[email protected]>

* Add filter functions to list view

Signed-off-by: Mirko Mollik <[email protected]>

* update cli

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update dependencies

Signed-off-by: Mirko Mollik <[email protected]>

* add merge script to build step

Signed-off-by: Mirko Mollik <[email protected]>

* improve tooltip handling

Signed-off-by: Mirko Mollik <[email protected]>

* improve add wallet dialog

Signed-off-by: Mirko Mollik <[email protected]>

* add filter to fragment

Signed-off-by: Mirko Mollik <[email protected]>

* update angular

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update material

Signed-off-by: Mirko Mollik <[email protected]>

* fix: add maintainer file (#25)

Signed-off-by: Mirko Mollik <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* fix: add info icon (but it's hidden right now)

Signed-off-by: Mirko Mollik <[email protected]>

* fix: include vertical lines

Signed-off-by: Mirko Mollik <[email protected]>

* hide icons for now

Signed-off-by: Mirko Mollik <[email protected]>

* fix: sorting name column

Signed-off-by: Mirko Mollik <[email protected]>

* Update wallets.json with igrant.io (#13)

from PR old repo

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* Flatten and new chars (#17)

* adding the stylesheet

Signed-off-by: Maaike van Leuken <[email protected]>

* added new characteristics and flattened structure

Signed-off-by: Maaike van Leuken <[email protected]>

* fix camel-casing, better naming of characteristics and removing of separate wallet files

Signed-off-by: Maaike van Leuken <[email protected]>

* adjusted js file to new characteristics and flattening

Signed-off-by: Maaike van Leuken <[email protected]>

* update js with flattening blockchain

Signed-off-by: Maaike van Leuken <[email protected]>

* adjusted accordingly the index.html

Signed-off-by: Maaike van Leuken <[email protected]>

* removed webApp boolean

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* Update script.js (#18)

import new flattened wallets document

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* Maaikevanleuken patch 7 (#20)

* Update script.js fixing names

Signed-off-by: Maaike van Leuken <[email protected]>

* Update index.html

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* replace application with angular, restructure wallet data

Signed-off-by: Mirko Mollik <[email protected]>

* let the ci also run on the angular branch for test purposes

Signed-off-by: Mirko Mollik <[email protected]>

* update ci jobs

Signed-off-by: Mirko Mollik <[email protected]>

* fix ci errors

Signed-off-by: Mirko Mollik <[email protected]>

* set correct version for upload artifact

Signed-off-by: Mirko Mollik <[email protected]>

* fix dist path

Signed-off-by: Mirko Mollik <[email protected]>

* increase build warnings

Signed-off-by: Mirko Mollik <[email protected]>

* set correct basehref

Signed-off-by: Mirko Mollik <[email protected]>

* remove angular icon

Signed-off-by: Mirko Mollik <[email protected]>

* set correct fetch path

Signed-off-by: Mirko Mollik <[email protected]>

* add some comments

Signed-off-by: Mirko Mollik <[email protected]>

* add info panel

Signed-off-by: Mirko Mollik <[email protected]>

* include show page for wallets

Signed-off-by: Mirko Mollik <[email protected]>

* update info

Signed-off-by: Mirko Mollik <[email protected]>

* outcomment migration job

Signed-off-by: Mirko Mollik <[email protected]>

* make contact button optional

Signed-off-by: Mirko Mollik <[email protected]>

* add dummy for credential formats

Signed-off-by: Mirko Mollik <[email protected]>

* add all entries for sig linking

Signed-off-by: Mirko Mollik <[email protected]>

* Add filter functions to list view

Signed-off-by: Mirko Mollik <[email protected]>

* update cli

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update dependencies

Signed-off-by: Mirko Mollik <[email protected]>

* add merge script to build step

Signed-off-by: Mirko Mollik <[email protected]>

* improve tooltip handling

Signed-off-by: Mirko Mollik <[email protected]>

* improve add wallet dialog

Signed-off-by: Mirko Mollik <[email protected]>

* add filter to fragment

Signed-off-by: Mirko Mollik <[email protected]>

* update angular

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update material

Signed-off-by: Mirko Mollik <[email protected]>

* fix: add maintainer file (#25)

Signed-off-by: Mirko Mollik <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* fix: add info icon (but it's hidden right now)

Signed-off-by: Mirko Mollik <[email protected]>

* fix: include vertical lines

Signed-off-by: Mirko Mollik <[email protected]>

* hide icons for now

Signed-off-by: Mirko Mollik <[email protected]>

* fix: sorting name column

Signed-off-by: Mirko Mollik <[email protected]>

* Update readme with motivation for contributors (#22)

* adding the stylesheet

Signed-off-by: Maaike van Leuken <[email protected]>

* added slides of previous meetings

Signed-off-by: Maaike van Leuken <[email protected]>

* Update README.md

Added motivation for contributors

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Maaike van Leuken <[email protected]>

* Update README.md (#41)

remove randomised entries in overview, based on issue #40

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* fix: only run it on the main branch

Signed-off-by: Mirko Mollik <[email protected]>

* add vidua wallet

Signed-off-by: Mirko Mollik <[email protected]>

* fix: add missing wallet icons and resize them

Signed-off-by: Mirko Mollik <[email protected]>

* fix: present links to app in a row

Signed-off-by: Mirko Mollik <[email protected]>

* fix: styling of app column

Signed-off-by: Mirko Mollik <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Maaike van Leuken <[email protected]>
Co-authored-by: Maaike van Leuken <[email protected]>
cre8 added a commit that referenced this pull request Apr 7, 2024
* WIP: Migration to new approach (#26)

* Maaikevanleuken patch 7 (#20)

* Update script.js fixing names

Signed-off-by: Maaike van Leuken <[email protected]>

* Update index.html

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* replace application with angular, restructure wallet data

Signed-off-by: Mirko Mollik <[email protected]>

* let the ci also run on the angular branch for test purposes

Signed-off-by: Mirko Mollik <[email protected]>

* update ci jobs

Signed-off-by: Mirko Mollik <[email protected]>

* fix ci errors

Signed-off-by: Mirko Mollik <[email protected]>

* set correct version for upload artifact

Signed-off-by: Mirko Mollik <[email protected]>

* fix dist path

Signed-off-by: Mirko Mollik <[email protected]>

* increase build warnings

Signed-off-by: Mirko Mollik <[email protected]>

* set correct basehref

Signed-off-by: Mirko Mollik <[email protected]>

* remove angular icon

Signed-off-by: Mirko Mollik <[email protected]>

* set correct fetch path

Signed-off-by: Mirko Mollik <[email protected]>

* add some comments

Signed-off-by: Mirko Mollik <[email protected]>

* add info panel

Signed-off-by: Mirko Mollik <[email protected]>

* include show page for wallets

Signed-off-by: Mirko Mollik <[email protected]>

* update info

Signed-off-by: Mirko Mollik <[email protected]>

* outcomment migration job

Signed-off-by: Mirko Mollik <[email protected]>

* make contact button optional

Signed-off-by: Mirko Mollik <[email protected]>

* add dummy for credential formats

Signed-off-by: Mirko Mollik <[email protected]>

* add all entries for sig linking

Signed-off-by: Mirko Mollik <[email protected]>

* Add filter functions to list view

Signed-off-by: Mirko Mollik <[email protected]>

* update cli

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update dependencies

Signed-off-by: Mirko Mollik <[email protected]>

* add merge script to build step

Signed-off-by: Mirko Mollik <[email protected]>

* improve tooltip handling

Signed-off-by: Mirko Mollik <[email protected]>

* improve add wallet dialog

Signed-off-by: Mirko Mollik <[email protected]>

* add filter to fragment

Signed-off-by: Mirko Mollik <[email protected]>

* update angular

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update material

Signed-off-by: Mirko Mollik <[email protected]>

* fix: add maintainer file (#25)

Signed-off-by: Mirko Mollik <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* fix: add info icon (but it's hidden right now)

Signed-off-by: Mirko Mollik <[email protected]>

* fix: include vertical lines

Signed-off-by: Mirko Mollik <[email protected]>

* hide icons for now

Signed-off-by: Mirko Mollik <[email protected]>

* fix: sorting name column

Signed-off-by: Mirko Mollik <[email protected]>

* Update wallets.json with igrant.io (#13)

from PR old repo

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* Flatten and new chars (#17)

* adding the stylesheet

Signed-off-by: Maaike van Leuken <[email protected]>

* added new characteristics and flattened structure

Signed-off-by: Maaike van Leuken <[email protected]>

* fix camel-casing, better naming of characteristics and removing of separate wallet files

Signed-off-by: Maaike van Leuken <[email protected]>

* adjusted js file to new characteristics and flattening

Signed-off-by: Maaike van Leuken <[email protected]>

* update js with flattening blockchain

Signed-off-by: Maaike van Leuken <[email protected]>

* adjusted accordingly the index.html

Signed-off-by: Maaike van Leuken <[email protected]>

* removed webApp boolean

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* Update script.js (#18)

import new flattened wallets document

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* Maaikevanleuken patch 7 (#20)

* Update script.js fixing names

Signed-off-by: Maaike van Leuken <[email protected]>

* Update index.html

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* replace application with angular, restructure wallet data

Signed-off-by: Mirko Mollik <[email protected]>

* let the ci also run on the angular branch for test purposes

Signed-off-by: Mirko Mollik <[email protected]>

* update ci jobs

Signed-off-by: Mirko Mollik <[email protected]>

* fix ci errors

Signed-off-by: Mirko Mollik <[email protected]>

* set correct version for upload artifact

Signed-off-by: Mirko Mollik <[email protected]>

* fix dist path

Signed-off-by: Mirko Mollik <[email protected]>

* increase build warnings

Signed-off-by: Mirko Mollik <[email protected]>

* set correct basehref

Signed-off-by: Mirko Mollik <[email protected]>

* remove angular icon

Signed-off-by: Mirko Mollik <[email protected]>

* set correct fetch path

Signed-off-by: Mirko Mollik <[email protected]>

* add some comments

Signed-off-by: Mirko Mollik <[email protected]>

* add info panel

Signed-off-by: Mirko Mollik <[email protected]>

* include show page for wallets

Signed-off-by: Mirko Mollik <[email protected]>

* update info

Signed-off-by: Mirko Mollik <[email protected]>

* outcomment migration job

Signed-off-by: Mirko Mollik <[email protected]>

* make contact button optional

Signed-off-by: Mirko Mollik <[email protected]>

* add dummy for credential formats

Signed-off-by: Mirko Mollik <[email protected]>

* add all entries for sig linking

Signed-off-by: Mirko Mollik <[email protected]>

* Add filter functions to list view

Signed-off-by: Mirko Mollik <[email protected]>

* update cli

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update dependencies

Signed-off-by: Mirko Mollik <[email protected]>

* add merge script to build step

Signed-off-by: Mirko Mollik <[email protected]>

* improve tooltip handling

Signed-off-by: Mirko Mollik <[email protected]>

* improve add wallet dialog

Signed-off-by: Mirko Mollik <[email protected]>

* add filter to fragment

Signed-off-by: Mirko Mollik <[email protected]>

* update angular

Signed-off-by: Mirko Mollik <[email protected]>

* fix: update material

Signed-off-by: Mirko Mollik <[email protected]>

* fix: add maintainer file (#25)

Signed-off-by: Mirko Mollik <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* fix: add info icon (but it's hidden right now)

Signed-off-by: Mirko Mollik <[email protected]>

* fix: include vertical lines

Signed-off-by: Mirko Mollik <[email protected]>

* hide icons for now

Signed-off-by: Mirko Mollik <[email protected]>

* fix: sorting name column

Signed-off-by: Mirko Mollik <[email protected]>

* Update readme with motivation for contributors (#22)

* adding the stylesheet

Signed-off-by: Maaike van Leuken <[email protected]>

* added slides of previous meetings

Signed-off-by: Maaike van Leuken <[email protected]>

* Update README.md

Added motivation for contributors

Signed-off-by: Maaike van Leuken <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Maaike van Leuken <[email protected]>

* Update README.md (#41)

remove randomised entries in overview, based on issue #40

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>

* fix: only run it on the main branch

Signed-off-by: Mirko Mollik <[email protected]>

* add vidua wallet

Signed-off-by: Mirko Mollik <[email protected]>

* fix: add missing wallet icons and resize them

Signed-off-by: Mirko Mollik <[email protected]>

* fix: present links to app in a row

Signed-off-by: Mirko Mollik <[email protected]>

* fix: styling of app column

Signed-off-by: Mirko Mollik <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Maaike van Leuken <[email protected]>
Co-authored-by: Maaike van Leuken <[email protected]>

* fix: update packages

Signed-off-by: Mirko Mollik <[email protected]>

* fix: only run on main

Signed-off-by: Mirko Mollik <[email protected]>

* fix: run on next

Signed-off-by: Mirko Mollik <[email protected]>

* fix: add lissi wallet

Signed-off-by: Mirko Mollik <[email protected]>

* Next (#44)

* fix: only show the company name

Signed-off-by: Mirko Mollik <[email protected]>

* fix: set correct name

Signed-off-by: Mirko Mollik <[email protected]>

* add old overview to github page

Signed-off-by: Mirko Mollik <[email protected]>

* fix: change branch to main so it can be merged

Signed-off-by: Mirko Mollik <[email protected]>

---------

Signed-off-by: Mirko Mollik <[email protected]>

* fix: set correct path for badge

Signed-off-by: Mirko Mollik <[email protected]>

* fix(ci): remove angular branch reference

Signed-off-by: Mirko Mollik <[email protected]>

---------

Signed-off-by: Maaike van Leuken <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Maaike van Leuken <[email protected]>
Co-authored-by: Maaike van Leuken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants