-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename to Credo #143
refactor: rename to Credo #143
Conversation
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Renames all occurrences of "Aries JavaScript" to "Credo". > NOTE: this change is not applied to the directory. Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Replaces all occurrences of the following strings with "Credo" - Aries Framework JavaScript - Aries Framework JavaScript (AFJ) - Hyperledger Aries Framework JavaScript - Hyperledger Aries Framework JavaScript (AFJ) Regex pattern used: `\b(?:Hyperledger )?Aries Framework JavaScript(?: \(AFJ\))?` > NOTE: this change is not applied to the directory Signed-off-by: Karim Stekelenburg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small comments, see you weren't finished yet but these were all related to the items you marked as ✅
Co-authored-by: Timo Glastra <[email protected]> Signed-off-by: Karim Stekelenburg <[email protected]>
Co-authored-by: Timo Glastra <[email protected]> Signed-off-by: Karim Stekelenburg <[email protected]>
Co-authored-by: Timo Glastra <[email protected]> Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Co-authored-by: Timo Glastra <[email protected]> Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits, but looks good! Going to merge already, can you do the other ones in a follow up?
@@ -4,7 +4,7 @@ | |||
|
|||
repository: | |||
name: credo-ts-docs | |||
description: Extension libraries for Aries Framework JavaScript | |||
description: Extension libraries for Credo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Extension libraries for Credo | |
description: Documentation for Credo |
@@ -6,7 +6,7 @@ | |||
height="250px" | |||
/> | |||
</p> | |||
<h1 align="center"><b>Aries JavaScript Documentation</b></h1> | |||
<h1 align="center"><b>Credo Documentation</b></h1> | |||
<p align="center"> | |||
<a | |||
href="https://raw.githubusercontent.com/hyperledger/aries-framework-javascript/main/LICENSE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated link (i think we should do a find al on aries-framework-javascript and hyperledger as well
</p> | ||
|
||
Aries JavaScipt is an ecosystem of self-sovereign identity development tools, with [Aries Framework JavaScipt](https://github.com/hyperledger/aries-framework-javascript) at the center. This documentation site serves to make it as easy as possible for developers of any level to get started with building self-sovereign identity solutions. | ||
Credo is an ecosystem of self-sovereign identity development tools, with [Credo](https://github.com/openwallet-foundation/credo-ts) at the center. This documentation site serves to make it as easy as possible for developers of any level to get started with building self-sovereign identity solutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sentence doesn't make full sense anymore
title: 'Aries JavaScript Documentation', | ||
tagline: 'Everything you need to know about the Aries JavaScript ecosystem.', | ||
title: 'Credo', | ||
tagline: 'Everything you need to know about the Credo TS ecosystem.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tagline: 'Everything you need to know about the Credo TS ecosystem.', | |
tagline: 'Everything you need to know about the Credo ecosystem.', |
{ | ||
label: 'Hyperledger Aries Mailing List', | ||
href: 'https://lists.hyperledger.org/g/aries', | ||
href: 'https://discord.com/channels/1022962884864643214/1179453305856991263', | ||
}, | ||
{ | ||
label: 'Working Group Call Notes', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should point to wiki in github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also working group calendar can be removed, we have the wiki that lists both (line below)
When working with any Aries implementation, you will interact with an Aries | ||
agent. This will be either directly or via a REST API, like [the Aries | ||
When working with any Credo implementation, you will interact with an Credo | ||
agent. This will be either directly or via a REST API, like [the Credo | ||
framework REST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove framework -- just Credo REST Api
| [`@aries-framework/push-notifications`](https://www.npmjs.com/package/@aries-framework/push-notifications) | ![@aries-framework/push-notifications version](https://img.shields.io/npm/v/@aries-framework/push-notifications) | Push notification plugin for Aries Framework JavaScript | | ||
| Package | Version | Description | | ||
| ---------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | | ||
| [`@aries-framework/redux-store`](https://www.npmjs.com/package/@aries-framework/redux-store) | ![@aries-framework/redux-store version](https://img.shields.io/npm/v/@aries-framework/redux-store) | Redux toolkit wrapper around Credo | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also update the package names already . Or do you want to do it in a separate pr
@@ -84,4 +84,4 @@ agentDependencies.indy.setLogger((level, target, message, modulePath, file, line | |||
> WARNING: You can only set the logger once. Call indy_set_default_logger, indy_set_logger, not both. Once it's been set, libindy won't let you change it. | |||
|
|||
You can also set the environment variable `RUST_LOG` to log at specified log levels. | |||
See https://crates.io/crates/env_logger for more information. | |||
See <https://crates.io/crates/env_logger> for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional?
@@ -208,7 +208,7 @@ connectionImageUrl: 'https://picsum.photos/200' | |||
|
|||
Whether the storage should automatically be updated when a newer version of | |||
[Aries Framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still AFJ
Todo
Follow-up PR