Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename to Credo #143

Merged

Conversation

karimStekelenburg
Copy link
Contributor

@karimStekelenburg karimStekelenburg commented Jan 24, 2024

Todo

  • Freeze 0.4 versioned docs
  • Freeze 0.4 snippets
  • Rename all mentions of "Aries JavaScript" to "Credo"
  • Rename all mentions of "Aries Framework JavaScript" to "Credo"
  • Remove mentions of "AFJ"
  • Update repository links

Follow-up PR

  • Update logo
  • Update social preview
  • Edit home page and mention the project's history
  • Add blog functionality
  • Write and publish post about the rebranding

Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Renames all occurrences of "Aries JavaScript" to "Credo".

> NOTE: this change is not applied to the  directory.

Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Replaces all occurrences of the following strings with "Credo"
- Aries Framework JavaScript
- Aries Framework JavaScript (AFJ)
- Hyperledger Aries Framework JavaScript
- Hyperledger Aries Framework JavaScript (AFJ)

Regex pattern used: `\b(?:Hyperledger )?Aries Framework JavaScript(?: \(AFJ\))?`

> NOTE: this change is not applied to the  directory

Signed-off-by: Karim Stekelenburg <[email protected]>
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments, see you weren't finished yet but these were all related to the items you marked as ✅

docusaurus.config.js Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
guides/concepts/agents.md Outdated Show resolved Hide resolved
guides/ecosystem/index.md Outdated Show resolved Hide resolved
guides/ecosystem/index.md Outdated Show resolved Hide resolved
guides/ecosystem/index.md Outdated Show resolved Hide resolved
guides/getting-started/set-up/index.md Outdated Show resolved Hide resolved
karimStekelenburg and others added 11 commits January 25, 2024 12:39
Co-authored-by: Timo Glastra <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
@karimStekelenburg karimStekelenburg marked this pull request as ready for review January 29, 2024 17:24
Signed-off-by: Karim Stekelenburg <[email protected]>
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, but looks good! Going to merge already, can you do the other ones in a follow up?

@@ -4,7 +4,7 @@

repository:
name: credo-ts-docs
description: Extension libraries for Aries Framework JavaScript
description: Extension libraries for Credo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Extension libraries for Credo
description: Documentation for Credo

@@ -6,7 +6,7 @@
height="250px"
/>
</p>
<h1 align="center"><b>Aries JavaScript Documentation</b></h1>
<h1 align="center"><b>Credo Documentation</b></h1>
<p align="center">
<a
href="https://raw.githubusercontent.com/hyperledger/aries-framework-javascript/main/LICENSE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated link (i think we should do a find al on aries-framework-javascript and hyperledger as well

</p>

Aries JavaScipt is an ecosystem of self-sovereign identity development tools, with [Aries Framework JavaScipt](https://github.com/hyperledger/aries-framework-javascript) at the center. This documentation site serves to make it as easy as possible for developers of any level to get started with building self-sovereign identity solutions.
Credo is an ecosystem of self-sovereign identity development tools, with [Credo](https://github.com/openwallet-foundation/credo-ts) at the center. This documentation site serves to make it as easy as possible for developers of any level to get started with building self-sovereign identity solutions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence doesn't make full sense anymore

title: 'Aries JavaScript Documentation',
tagline: 'Everything you need to know about the Aries JavaScript ecosystem.',
title: 'Credo',
tagline: 'Everything you need to know about the Credo TS ecosystem.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tagline: 'Everything you need to know about the Credo TS ecosystem.',
tagline: 'Everything you need to know about the Credo ecosystem.',

{
label: 'Hyperledger Aries Mailing List',
href: 'https://lists.hyperledger.org/g/aries',
href: 'https://discord.com/channels/1022962884864643214/1179453305856991263',
},
{
label: 'Working Group Call Notes',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should point to wiki in github

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also working group calendar can be removed, we have the wiki that lists both (line below)

When working with any Aries implementation, you will interact with an Aries
agent. This will be either directly or via a REST API, like [the Aries
When working with any Credo implementation, you will interact with an Credo
agent. This will be either directly or via a REST API, like [the Credo
framework REST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove framework -- just Credo REST Api

| [`@aries-framework/push-notifications`](https://www.npmjs.com/package/@aries-framework/push-notifications) | ![@aries-framework/push-notifications version](https://img.shields.io/npm/v/@aries-framework/push-notifications) | Push notification plugin for Aries Framework JavaScript |
| Package | Version | Description |
| ---------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- |
| [`@aries-framework/redux-store`](https://www.npmjs.com/package/@aries-framework/redux-store) | ![@aries-framework/redux-store version](https://img.shields.io/npm/v/@aries-framework/redux-store) | Redux toolkit wrapper around Credo |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also update the package names already . Or do you want to do it in a separate pr

@@ -84,4 +84,4 @@ agentDependencies.indy.setLogger((level, target, message, modulePath, file, line
> WARNING: You can only set the logger once. Call indy_set_default_logger, indy_set_logger, not both. Once it's been set, libindy won't let you change it.

You can also set the environment variable `RUST_LOG` to log at specified log levels.
See https://crates.io/crates/env_logger for more information.
See <https://crates.io/crates/env_logger> for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

@@ -208,7 +208,7 @@ connectionImageUrl: 'https://picsum.photos/200'

Whether the storage should automatically be updated when a newer version of
[Aries Framework
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still AFJ

@TimoGlastra TimoGlastra merged commit 013aaf0 into openwallet-foundation:main Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants