Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data retention history display #943

Merged

Conversation

wadeking98
Copy link
Contributor

Summary of Changes

Added conditional rendering to only show the usage history button if data retention is turned on

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@wadeking98 wadeking98 requested a review from a team as a code owner August 28, 2023 22:49
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #943 (c1b49ec) into main (ce2d69a) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
+ Coverage   58.63%   58.66%   +0.02%     
==========================================
  Files         177      177              
  Lines        4939     4942       +3     
  Branches     1372     1374       +2     
==========================================
+ Hits         2896     2899       +3     
  Misses       2019     2019              
  Partials       24       24              
Files Changed Coverage Δ
...es/legacy/core/App/screens/ProofRequestDetails.tsx 68.80% <75.00%> (+0.88%) ⬆️

@@ -185,6 +186,7 @@ const ProofRequestAttributesCard: React.FC<ProofRequestAttributesCardParams> = (

const ProofRequestDetails: React.FC<ProofRequestDetailsProps> = ({ route, navigation }) => {
const { ColorPallet, TextTheme } = useTheme()
const [store,] = useStore()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comma needed?

bryce-mcmath
bryce-mcmath previously approved these changes Aug 28, 2023
Signed-off-by: wadeking98 <[email protected]>
@wadeking98 wadeking98 merged commit e83ae93 into openwallet-foundation:main Aug 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants