Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added button to request decline screen #940

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Aug 23, 2023

Summary of Changes

@wadeking98 is way for a week so I fixed the outdated snapshot in PR #938. I cannot push to his branch so I've created this one. As per his original comment:

Added request another proof request button to mobile verifier decline screen:

image

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #940 (a58fb80) into main (a8bb8ae) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   57.98%   57.95%   -0.03%     
==========================================
  Files         176      176              
  Lines        4929     4935       +6     
  Branches     1369     1371       +2     
==========================================
+ Hits         2858     2860       +2     
- Misses       2047     2051       +4     
  Partials       24       24              
Files Changed Coverage Δ
packages/legacy/core/App/screens/ProofDetails.tsx 71.62% <37.50%> (-3.38%) ⬇️

@jleach jleach marked this pull request as ready for review August 23, 2023 00:30
@jleach jleach requested a review from a team as a code owner August 23, 2023 00:30
@jleach jleach force-pushed the fix/wadeking98-pr938 branch 4 times, most recently from 00db0c0 to a58fb80 Compare August 23, 2023 22:46
wadeking98 and others added 5 commits August 23, 2023 16:25
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach merged commit ce2d69a into openwallet-foundation:main Aug 23, 2023
3 checks passed
@jleach jleach deleted the fix/wadeking98-pr938 branch August 23, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants