Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added data retention option #935

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

wadeking98
Copy link
Contributor

@wadeking98 wadeking98 commented Aug 18, 2023

Summary of Changes

Added settings data retention option to allow or prevent saving proof records in the wallet during usage of the mobile verifier

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@wadeking98 wadeking98 requested a review from a team as a code owner August 18, 2023 22:43
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #935 (f32d492) into main (4f217d7) will decrease coverage by 0.01%.
The diff coverage is 51.72%.

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   52.35%   52.34%   -0.01%     
==========================================
  Files         177      178       +1     
  Lines        4955     4984      +29     
  Branches     1367     1372       +5     
==========================================
+ Hits         2594     2609      +15     
- Misses       2341     2355      +14     
  Partials       20       20              
Files Changed Coverage Δ
packages/legacy/core/App/contexts/store.tsx 87.50% <ø> (ø)
packages/legacy/core/App/localization/en/index.ts 100.00% <ø> (ø)
packages/legacy/core/App/localization/fr/index.ts 100.00% <ø> (ø)
...ckages/legacy/core/App/localization/pt-br/index.ts 100.00% <ø> (ø)
...ckages/legacy/core/App/navigators/SettingStack.tsx 5.55% <ø> (ø)
packages/legacy/core/App/screens/Settings.tsx 3.57% <0.00%> (-0.14%) ⬇️
...ackages/legacy/core/App/contexts/reducers/store.ts 14.61% <25.00%> (+0.50%) ⬆️
packages/legacy/core/App/screens/DataRetention.tsx 64.28% <64.28%> (ø)
packages/legacy/core/App/screens/ProofDetails.tsx 75.00% <80.00%> (+0.39%) ⬆️

Signed-off-by: wadeking98 <[email protected]>
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

@wadeking98 wadeking98 merged commit f389678 into openwallet-foundation:main Aug 21, 2023
3 of 5 checks passed
@thiagoromanos
Copy link
Contributor

Since mobile verifier is a developer option, shouldn't this one be too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants