-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add proof predicate evaluation #931
feat: add proof predicate evaluation #931
Conversation
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #931 +/- ##
==========================================
+ Coverage 52.37% 54.97% +2.59%
==========================================
Files 178 178
Lines 4987 5024 +37
Branches 1374 1393 +19
==========================================
+ Hits 2612 2762 +150
+ Misses 2355 2241 -114
- Partials 20 21 +1
|
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
Is it possible to change the wording so it's more plain language? for example: The content above from "you do not have data that satisfies the predicate" to: "You do not meet the requirements of this proof request from [verifier name]" and the message below the attribute from "Predicate not satisfied" to "Requirement not met"? |
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Can we get this up to date with main next week so we can merge it in?
Summary of Changes
Evaluates if proof predicates are satisfied. If not satisfied, displays an error message.
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.