-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding toast notification #876
feat: adding toast notification #876
Conversation
Signed-off-by: Caroline Lucas Calheirani <[email protected]>
…otification' into feat/adding-toast-notification Signed-off-by: Caroline Lucas Calheirani <[email protected]>
@CarolineLCa If you update the base branch we can get this one merged in. You may need to write a test somewhere in the app if CodeCov complains. We can't merge any PRs that notably drop our code coverage. But any test would help I think. |
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
==========================================
+ Coverage 52.37% 54.93% +2.55%
==========================================
Files 178 178
Lines 4987 5028 +41
Branches 1374 1393 +19
==========================================
+ Hits 2612 2762 +150
+ Misses 2355 2245 -110
- Partials 20 21 +1
|
The UI/UX team thinks these toasts aren't entirely necessary, partially because the user can see the original notification disappear. Ok if we close this one? |
Summary of Changes
Adding toast notifications to
Decline
action where they were missing:Before
Screen_Recording_20230707_124753_Aries.Bifold.mp4
Now
Screen_Recording_20230707_141004_Aries.Bifold.mp4
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.