Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check proof state before fetch #1313

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

jleach
Copy link
Contributor

@jleach jleach commented Nov 12, 2024

Summary of Changes

Confirm the state of the proof before fetching credentials for it.

Related Issues

n/a

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@jleach jleach marked this pull request as ready for review November 12, 2024 21:38
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for getting rid of the Promise.all and making them run consecutively?

Signed-off-by: Jason C. Leach <[email protected]>
Copy link

sonarcloud bot commented Nov 12, 2024

@jleach
Copy link
Contributor Author

jleach commented Nov 12, 2024

Reason for getting rid of the Promise.all and making them run consecutively?

No good reason. I though it looked cleaner. I gave it a test and it does run slightly faster with it so I added it back.

Without Promise All: 489 ms, 393 ms
With Promise All: 307 ms, 325 ms

@bryce-mcmath bryce-mcmath merged commit 6fcd666 into main Nov 12, 2024
7 checks passed
@bryce-mcmath bryce-mcmath deleted the fix/proof-state-check branch November 12, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants