Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proof request missing attribute #1307

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Nov 7, 2024

Summary of Changes

  • Updated proof request logic to specify attributes that are missing from a wallet and adds a 'missing' label
  • Updated snapshots to account for new UI
  • added 'errorMessage' to display errors
  • The below photo shows a proof request made for an attribute (photo) that 'Basic Credential' doesn't have:

Screenshot_2024-11-08-16-02-17-67_5311491dc7ccfea1973777bf62591d94

Related Issues

BC Wallet: 2208

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.80%. Comparing base (f475eed) to head (0600f4f).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...gacy/core/App/components/misc/CredentialCard11.tsx 71.42% 2 Missing ⚠️
packages/legacy/core/App/utils/helpers.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   57.12%   56.80%   -0.32%     
==========================================
  Files         204      213       +9     
  Lines        6980     7410     +430     
  Branches     1978     2096     +118     
==========================================
+ Hits         3987     4209     +222     
- Misses       2971     3179     +208     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@al-rosenthal al-rosenthal marked this pull request as ready for review November 8, 2024 23:04
@jleach jleach marked this pull request as draft November 14, 2024 18:23
Copy link

sonarcloud bot commented Nov 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants