feat: credential list footer component injectable #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
|
MosCD3
requested changes
Oct 1, 2024
|
The credential list screen also has an "add credential" button "represented by a "+" icon at the top right corner in the header. Does this PR take into account that button? I see in the screen posted above that that button is replaced with a "help" button. |
|
@knguyenBC the "add credential button" represented by a "+" icon at the top right corner can either be replaced by another component or removed. This component can be injected at the container level (by the default, it's null). For example: //container-impl.ts
// By default at bifold-wallet
this._container.registerInstance(TOKENS.COMPONENT_CRED_LIST_HEADER_RIGHT, () => null)
// In bc-wallet
this._container.registerInstance(TOKENS.COMPONENT_CRED_LIST_HEADER_RIGHT, AddCredentialButton)
// In qc-wallet
this._container.registerInstance(TOKENS.COMPONENT_CRED_LIST_HEADER_RIGHT, HelpCenterButton)Nothing needs to be changed after this PR is merged in other wallets (no impact). |
MosCD3
approved these changes
Oct 1, 2024
al-rosenthal
pushed a commit
to al-rosenthal/bifold-wallet
that referenced
this pull request
Oct 9, 2024
…ion#1266) Signed-off-by: fc-santos <[email protected]>
al-rosenthal
pushed a commit
to al-rosenthal/bifold-wallet
that referenced
this pull request
Oct 10, 2024
…ion#1266) Signed-off-by: fc-santos <[email protected]> Signed-off-by: al-rosenthal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds a new option to add a ListFooterComponent to the ListCredentials Screen in the FlatList. This option would for example allow other wallets to add a button in the footer of the list. Example:
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.