feat: new proof request loading screen #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleach
force-pushed
the
feat/new-prof-skelly
branch
from
c1ebcc9
to
e75f881
Compare
jleach
force-pushed
the
feat/new-prof-skelly
branch
5 times, most recently
from
988e505
to
a6c6cc4
Compare
jleach
force-pushed
the
feat/new-prof-skelly
branch
2 times, most recently
from
2d699ea
to
2d5875e
Compare
bryce-mcmath
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Should we not commit this file?
| @@ -10,6 +10,7 @@ import { | |||
| import { useBasicMessages, useCredentialByState, useProofByState } from '@credo-ts/react-hooks' | |||
| import { ProofCustomMetadata, ProofMetadata } from '@hyperledger/aries-bifold-verifier' | |||
| import { useEffect, useState } from 'react' | |||
| // import { log } from 'console' | |||
There was a problem hiding this comment.
should probably remove
Comment on lines
44
to
58
| marginLeft: 0, | ||
| backgroundColor: ColorPallet.grayscale.lightGrey, | ||
| width: 40, | ||
| borderTopLeftRadius: 15, | ||
| borderBottomLeftRadius: 15, | ||
| }} | ||
| /> | ||
| <View | ||
| style={{ | ||
| marginLeft: -22, | ||
| marginTop: 20, | ||
| backgroundColor: ColorPallet.grayscale.lightGrey, | ||
| height: 45, | ||
| width: 45, | ||
| borderRadius: 5, |
There was a problem hiding this comment.
These width / margin numbers seem somewhat arbitrary, could they be explained or named?
Comment on lines
61
to
65
| <View style={{ marginLeft: 15, marginTop: 15, marginBottom: 15 }}> | ||
| <View style={[myStyle.rectangle, { width: 240, height: 20 }]} /> | ||
| <View style={[myStyle.rectangle, { width: 145, height: 25 }]} /> | ||
| <View style={[myStyle.rectangle, { width: 75, height: 20, marginTop: 20 }]} /> | ||
| <View style={[myStyle.rectangle, { width: 210, height: 25 }]} /> |
bryce-mcmath
requested changes
Oct 1, 2024
jleach
force-pushed
the
feat/new-prof-skelly
branch
from
2d5875e
to
ffdf808
Compare
bryce-mcmath
previously approved these changes
Oct 2, 2024
|
The xcode file is still included but that isn't a big deal it's just an EOF |
It was just a EOF but I fixed it anyway. |
bryce-mcmath
approved these changes
Oct 2, 2024
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
jleach
force-pushed
the
feat/new-prof-skelly
branch
from
cb1c82f
to
6d784a5
Compare
|
al-rosenthal
pushed a commit
to al-rosenthal/bifold-wallet
that referenced
this pull request
Oct 9, 2024
Signed-off-by: Jason C. Leach <[email protected]>
al-rosenthal
pushed a commit
to al-rosenthal/bifold-wallet
that referenced
this pull request
Oct 10, 2024
Signed-off-by: Jason C. Leach <[email protected]> Signed-off-by: al-rosenthal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Improved loading experience and streamlined testing
react-hooks.ts, making tests easier to manage.This summary focuses on the key user-facing improvement (loading animations) and the behind-the-scenes benefit of centralized mock data, while also acknowledging the necessary test updates. It uses positive language and avoids technical jargon that might not be familiar to all reviewers.
Related Issues
n/a
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.