NPUW: Support NF4 DCOFF for CW models #27518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into at/npuw-nf4-dcoff-support
github-actions
bot
added
category: CPU
TolyaTalamanov
changed the title
dmatveev
approved these changes
Nov 13, 2024
| @@ -229,7 +229,8 @@ std::shared_ptr<ov::ICompiledModel> Plugin::compile_model(const std::shared_ptr< | |||
| ov::element::Type_t::f32, | |||
| ov::element::Type_t::f64, | |||
| ov::element::Type_t::boolean, | |||
| ov::element::Type_t::string}; | |||
| ov::element::Type_t::string, | |||
| ov::element::Type_t::nf4}; | |||
There was a problem hiding this comment.
Make sure the sorting order is correct here
Comment on lines
+312
to
318
| auto cvt = std::static_pointer_cast<ov::op::v0::Convert>(matched_convrt); | ||
| auto matmul = std::static_pointer_cast<ov::op::v0::MatMul>(matched_matmul); | ||
|
|
||
| // NB: In case convert and matmul types don't match | ||
| cvt->set_destination_type(matmul->inputs()[1].get_element_type()); | ||
|
|
||
| matched_matmul->input(1).replace_source_output(matched_convrt); |
There was a problem hiding this comment.
am I right that you may end up with
Parameter(f16) -> Convert(f32) -> MatMul(f32) ?
For DCOFF it probably still work though.
Comment on lines
55
to
58
| void unpack_nf4f16_scale(const ov::SoPtr<ov::ITensor>& from, | ||
| const ov::SoPtr<ov::ITensor>& scale, | ||
| const ov::SoPtr<ov::ITensor>& to, | ||
| const ov::npuw::util::UnpackOptions& unpack_options) { |
There was a problem hiding this comment.
no need here in _scale prefix as you take scale as an input (assuming such overloads of the unpack assume scale)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.