Allow to have the app set late for FlaskTracing. #24
Conversation
In other instrumentation code this is not reported, as it's not considered fatal.
* Add standard tags.
* Let the tracer be optional, and fallback to the global tracer. * Expose tracer as a property without trailing _.
This test used to be a dummy one, as we had lacked a MockTracer implementation, but now we have one.
|
Hey @denisdubovitskiy does this looks fine to you? Does this solve your needs? Let me know ;) |
|
@carlosalberto seems better enough ;-). But what if you need to initialize a tracer by configuring it from the app.config (I mean host, port, service name, etc? |
|
Init_app approach actually allows you to defer actual object creation/initialization. It means that if I call FlaskTracer() without any args and then pass an app in init_app() - the tracer will be initialized using app.conf vars during app creation, not on any other level. As an example you can see how other useful modules provide such a functionality. To get an idea, I recommend you to look into the sources of FlaskRedis or FlaskSQLAlchemy - most widely used ones |
|
I see. I'm going to rename the name to About the configuration being taken from |
This is done to make the app more Flask-esque.
|
Hi there! Is there a timeline for when this will be merged into master? This functionality is definitely super handy! |
|
@etmitchell @carlosalberto Yeah! We're also waiting for this PR to be merged! |
|
Any changes? |
|
Did this ever get merged? Seems like it passes checks, code is complete, etc. |
|
This package is no longer being maintained, users should migrate to the Closing. |
Addresses #22