-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OTSubscriberView, OTPublishderView layout issue on iOS #530
base: 0.18.1
Are you sure you want to change the base?
Conversation
Can you share screenshots? Not sure what you mean by doesn't layout properly |
There is nothing on the screen since the subscriber view height is 0. |
I haven't seen this behavior before. The sample apps work fine, can you share your React Native code? |
@abdulajet using BasicVideoChat example, I am able to reproduce the issue by setting
@DmitryTop for the Android issue, can you try by setting:
Documentation here: https://github.com/opentok/opentok-react-native/blob/main/docs/OTSession.md#setting-session-options |
Setting
|
I am not too knowledgable with JS/React but wouldnt you provide the size in JS? |
Setting BTW I am using the same view structure for Twilio and for Vonage. Twlio works, Vonage does not. You can check Twlio plugin implementation here https://github.com/actio-tech/react-native-twilio-video-webrtc (it's a fork of https://github.com/blackuy/react-native-twilio-video-webrtc) |
OTSubscriberView
andOTPublisherView
fail to layout properly on iOS. In my caselayoutSubviews
is called only once when the view has incorrect bounds (which are managed by React Native) with height = 0.