Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat.] Add AS Lifecycle Hook #732

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Conversation

muneeb-jan
Copy link
Member

@muneeb-jan muneeb-jan commented Oct 2, 2024

What this PR does / why we need it

Adds AS lifecycle hooks to GopherTelekomCloud.

Which issue this PR fixes

Fixes issue #731

Tests Performed

=== RUN   TestLifecycleHooksLifecycle
    helpers.go:73: Attempting to create AutoScaling Configuration
    helpers.go:98: Created AutoScaling Configuration: c582c684-bd51-484b-ae57-42f24945fc8b
    helpers.go:48: Attempting to create AutoScaling Group
    helpers.go:51: Created AutoScaling Group: 99c09047-3022-4744-86bb-7c35adf3e85d
    lifecycle_hooks_test.go:27: Attempting to create Topic: as-lifecycle-hooks-topic-VLV
    lifecycle_hooks_test.go:39: Attempting to create Lifecycle Hook
    lifecycle_hooks_test.go:42: Created Lifecycle Hook: as-lifecycle-hook-create-86u
    lifecycle_hooks_test.go:52: Attempting to update Lifecycle Hook
    lifecycle_hooks_test.go:57: Updated Lifecycle Hook: as-lifecycle-hook-create-86u
    lifecycle_hooks_test.go:59: Listing all Lifecycle Hooks
    tools.go:74: {
          "lifecycle_hook_name": "as-lifecycle-hook-create-86u",
          "lifecycle_hook_type": "INSTANCE_TERMINATING",
          "default_result": "ABANDON",
          "default_timeout": 4800,
          "notification_topic_urn": "urn:smn:eu-de:7b697e01b13e431aa3f4c8a7afe2046f:as-lifecycle-hooks-topic-VLV",
          "notification_topic_name": "as-lifecycle-hooks-topic-VLV",
          "notification_metadata": "",
          "create_time": "2024-10-07T13:10:06Z"
        }
    lifecycle_hooks_test.go:67: Attempting to delete Lifecycle Hook
    lifecycle_hooks_test.go:70: Deleted Lifecycle Hook: as-lifecycle-hook-create-86u
    helpers.go:122: Attempting to Delete Topic: urn:smn:eu-de:7b697e01b13e431aa3f4c8a7afe2046f:as-lifecycle-hooks-topic-VLV
    helpers.go:127: Deleted Topic: urn:smn:eu-de:7b697e01b13e431aa3f4c8a7afe2046f:as-lifecycle-hooks-topic-VLV
    helpers.go:60: Attempting to delete AutoScaling Group
    helpers.go:65: Deleted AutoScaling Group: 99c09047-3022-4744-86bb-7c35adf3e85d
    helpers.go:103: Attempting to delete AutoScaling Configuration
    helpers.go:106: Deleted AutoScaling Configuration: c582c684-bd51-484b-ae57-42f24945fc8b
--- PASS: TestLifecycleHooksLifecycle (12.01s)
PASS

@muneeb-jan muneeb-jan self-assigned this Oct 2, 2024
@muneeb-jan muneeb-jan added the enhancement New feature or request label Oct 2, 2024
Copy link
Member

@anton-sidelnikov anton-sidelnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@muneeb-jan
Copy link
Member Author

muneeb-jan commented Oct 4, 2024

Tests?

This one is not up for review yet.

@otc-zuul otc-zuul bot merged commit 2b3f497 into devel Oct 7, 2024
16 checks passed
@otc-zuul otc-zuul bot deleted the add-autoscaling-lifecycle-hooks branch October 7, 2024 13:26
@muneeb-jan muneeb-jan mentioned this pull request Oct 9, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants