Skip to content

Commit

Permalink
Merge pull request #239 from eshulman2/fix_extraconfigmap_pointer_issue
Browse files Browse the repository at this point in the history
Fix the nil pointing issue
  • Loading branch information
openshift-merge-bot[bot] authored Nov 11, 2024
2 parents 4cec605 + ec466fd commit 28d0922
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/ansibletest/volumes.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func GetVolumes(
volumes = append(volumes, extraVol)
}

if len(instance.Spec.Workflow) > 0 {
if len(instance.Spec.Workflow) > 0 && *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts != nil {
for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {
extraWorkflowVol := corev1.Volume{
Name: vol.Name,
Expand Down Expand Up @@ -204,7 +204,7 @@ func GetVolumeMounts(mountCerts bool, instance *testv1beta1.AnsibleTest, externa
volumeMounts = append(volumeMounts, extraConfigmapsMounts)
}

if len(instance.Spec.Workflow) > 0 {
if len(instance.Spec.Workflow) > 0 && *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts != nil {
for _, vol := range *instance.Spec.Workflow[externalWorkflowCounter].ExtraConfigmapsMounts {

extraConfigmapsMounts := corev1.VolumeMount{
Expand All @@ -217,5 +217,6 @@ func GetVolumeMounts(mountCerts bool, instance *testv1beta1.AnsibleTest, externa
volumeMounts = append(volumeMounts, extraConfigmapsMounts)
}
}

return volumeMounts
}

0 comments on commit 28d0922

Please sign in to comment.