Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set debug mode for Tempest #2307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdiazcam
Copy link
Contributor

@rdiazcam rdiazcam commented Sep 4, 2024

This change allows to enable the debug mode for the Tempest test operator by setting cifmw_test_operator_tempest_debug: true in spec (false by default). It must only be set to true for debbuging purposes (e.g. when running the operator manually) because it keeps the pod (e.g .Running) sleeping infinity.

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Sep 4, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b7b0bc76af8d4520af00e8b5bb93a6fa

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 27s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 44s
cifmw-multinode-tempest FAILURE in 17m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 09s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 01s
✔️ build-push-container-cifmw-client SUCCESS in 22m 14s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 11s

@lpiwowar
Copy link
Contributor

lpiwowar commented Sep 5, 2024

recheck

Thanks, looks good to me 👍 . I see no reason why not to expose this parameter. The job failure does not seem to be related to the patch:

  Traceback (most recent call last):
      File "/home/zuul/ci-framework-data/venv/bin/repo-setup-get-hash", line 10, in <module>
        sys.exit(cli_entrypoint())
      File "/home/zuul/ci-framework-data/venv/lib64/python3.9/site-packages/repo_setup/get_hash/__main__.py", line 117, in cli_entrypoint
        main()
      File "/home/zuul/ci-framework-data/venv/lib64/python3.9/site-packages/repo_setup/get_hash/__main__.py", line 89, in main
        repo_setup_hash_info = HashInfo(
      File "/home/zuul/ci-framework-data/venv/lib64/python3.9/site-packages/repo_setup/get_hash/hash_info.py", line 153, in __init__
        raise HashInvalidDLRNResponse(error_str)
    repo_setup.get_hash.exceptions.HashInvalidDLRNResponse: Invalid response received from the delorean server. Queried URL: https://trunk.rdoproject.org/centos9-antelope/current-podified/delorean.repo.md5. Response code: -1. Response text: The read operation timed out. Failed to create HashInfo object.
  stderr_lines: <omitted>
  stdout: '2024-09-04 06:05:32,642 - repo-setup-get-hash - ERROR - Invalid response received from the delorean server. Queried URL: https://trunk.rdoproject.org/centos9-antelope/current-podified/delorean.repo.md5. Response code: -1. Response text: The read operation timed out. Failed to create HashInfo object.'
  stdout_lines: <omitted>

@rdiazcam
Copy link
Contributor Author

rdiazcam commented Sep 6, 2024

recheck

This change allows to enable the debug mode for the Tempest test
operator by setting `cifmw_test_operator_tempest_debug: true` in spec
(false by default). It must only be set to true for debbuging purposes
(e.g. when running the operator manually) because it keeps the pod
(e.g .Running) sleeping infinity.
@rdiazcam rdiazcam marked this pull request as ready for review September 6, 2024 10:27
@@ -87,6 +87,7 @@ cifmw_tempest_tempestconf_config_defaults:
enforce_scope = false

# Please refer to https://openstack-k8s-operators.github.io/test-operator/guide.html#executing-tempest-tests
cifmw_test_operator_tempest_debug: false
cifmw_test_operator_tempest_config:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a proper data structure, I'm wondering if we shouldn't:

  • push a cifmw_test_operator_tempest_default_config in vars/main.yml
  • update cifmw_test_operator_tempest_config to be mostly empty
  • combine both dict before generating the configuration file

That way, we could get something really nice and provide a better interface. Avoiding that kind of PR.

Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants