Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to leverage tags when running architecture deployment #2275

Closed
wants to merge 1 commit into from

Conversation

cjeanner
Copy link
Collaborator

The nfs.yml playbook is imported from the 06-deploy-edpm.yml
sub-playbook. Due to the way ansible imports things, it was leading to
an issue if we wanted to run an architecture driven deployment, with
"--tags deploy_edpm" parameter.
This deploy_edpm tag is shared between 06-deploy-edpm.yml and
06-deploy-architecure.yml playbooks, meaning it would run through both.

The exit condition in the 06-deploy-edpm.yml play was missing the check
on cifmw_architecture_scenario we usually have, leading to issues
because of undefined facts (ansible_user_dir, ansible_env) from the
compute nodes.

This patch should allow to avoid this issue in a clean way.

The nfs.yml playbook is imported from the 06-deploy-edpm.yml
sub-playbook. Due to the way ansible imports things, it was leading to
an issue if we wanted to run an architecture driven deployment, with
"--tags deploy_edpm" parameter.
This deploy_edpm tag is shared between 06-deploy-edpm.yml and
06-deploy-architecure.yml playbooks, meaning it would run through both.

The exit condition in the 06-deploy-edpm.yml play was missing the check
on cifmw_architecture_scenario we usually have, leading to issues
because of undefined facts (ansible_user_dir, ansible_env) from the
compute nodes.

This patch should allow to avoid this issue in a clean way.
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cjeanner. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjeanner cjeanner marked this pull request as ready for review August 28, 2024 08:30
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6d9027f1baa6490398f0b0666d33fed3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 09s
podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 10s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 52s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 02s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 14s

Copy link

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 22, 2024
@github-actions github-actions bot closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant