dnsmasq - use dhcp-hostdir #1801
Conversation
|
Thanks for the PR! ❤️ |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/59aed376b88148db9db4aa488a6f66cc ✔️ noop SUCCESS in 0s |
|
recheck |
|
/retest |
hjensas
force-pushed
the
dnsmasq-use-dhcp-hosts-opts-dir
branch
from
c74835a
to
76d93e6
Compare
hjensas
force-pushed
the
dnsmasq-use-dhcp-hosts-opts-dir
branch
from
76d93e6
to
c18602e
Compare
hjensas
force-pushed
the
dnsmasq-use-dhcp-hosts-opts-dir
branch
from
c18602e
to
7f84b99
Compare
The restart done by the handler happens only at the very end of the play. By using dhcp-hostsdir we get the benefit of dnsmasq reading any new or changed file in the hosts dir, automatically applying the new dhcp host config on the fly. Since adding a host is loaded on-the-fly - we don't need to notify the handler when adding hosts. Removing hosts however, reqires s SIGHUP - so for that case notify the handler. Also change the computation of _host_entry - it should include both ipv4 and ipv6 address if both are configured.
hjensas
force-pushed
the
dnsmasq-use-dhcp-hosts-opts-dir
branch
from
7f84b99
to
9a92a44
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9bf7bb6
into
openstack-k8s-operators:main
The restart done by the handler happens only at the very end of the play. By using dhcp-hostsdir we get the benefit of dnsmasq reading any new or changed file in the hosts dir, automatically applying the new dhcp host config on the fly.
Since adding a host is loaded on-the-fly - we don't need to notify the handler when adding hosts.
Removing hosts however, reqires s SIGHUP - so for that case notify the handler.
Also change the computation of _host_entry - it should include both ipv4 and ipv6 address if both are configured.
As a pull request owner and reviewers, I checked that: