Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to hostname rather than IP for validations check node #1797

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented May 31, 2024

This change switches the default value for cifmw_validations_edpm_check_node to use a hostname rather than an IP address. This will ensure we match against the Ansible inventory host and not depend on the IP address of that node always being the same.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@github-actions github-actions bot marked this pull request as draft May 31, 2024 02:18
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/12fdb70cf2a944d3828b67d880dbce2b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 16s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 18s
✔️ noop SUCCESS in 0s
cifmw-pod-ansible-test FAILURE in 5m 25s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 13s
✔️ cifmw-molecule-validations SUCCESS in 5m 00s

@lewisdenny
Copy link
Collaborator

recheck

ERROR! Failed to clone a Git repository from [https://github.com/ansible-collections/community.general.](https://github.com/ansible-collections/community.general%60.)

This change switches the default value for cifmw_validations_edpm_check_node
to use a hostname rather than an IP address. This will ensure we match against the
Ansible inventory host and not depend on the IP address of that node always being
the same.

Signed-off-by: Brendan Shephard <[email protected]>
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@pablintino
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit de7d0bf into openstack-k8s-operators:main Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants