-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to hostname rather than IP for validations check node #1797
Change to hostname rather than IP for validations check node #1797
Conversation
Thanks for the PR! ❤️ |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/12fdb70cf2a944d3828b67d880dbce2b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 01s |
recheck ERROR! Failed to clone a Git repository from |
This change switches the default value for cifmw_validations_edpm_check_node to use a hostname rather than an IP address. This will ensure we match against the Ansible inventory host and not depend on the IP address of that node always being the same. Signed-off-by: Brendan Shephard <[email protected]>
4911e5f
to
e53ec63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lewisdenny The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
de7d0bf
into
openstack-k8s-operators:main
This change switches the default value for cifmw_validations_edpm_check_node to use a hostname rather than an IP address. This will ensure we match against the Ansible inventory host and not depend on the IP address of that node always being the same.
As a pull request owner and reviewers, I checked that: