Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRs for uni01alpha deployed topology #83

Merged
merged 1 commit into from
Apr 19, 2024
Merged

CRs for uni01alpha deployed topology #83

merged 1 commit into from
Apr 19, 2024

Conversation

psathyan
Copy link
Contributor

@psathyan psathyan commented Jan 26, 2024 •
edited
Loading

This PR contains the custom resources based on Alpha DT type proposal of deploying and configuring OpenStack Services on OpenShift.

Logs

ci-framework

PLAY RECAP ***********************************************************************************************************************************************************************************************************************************
compute-0                  : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   
compute-1                  : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   
localhost                  : ok=365  changed=111  unreachable=0    failed=0    skipped=237  rescued=1    ignored=0   

Wednesday 17 April 2024  07:35:31 -0400 (0:00:00.184)       0:35:45.216 ******* 
=============================================================================== 
kustomize_deploy : Run Wait Conditions for examples/dt/uni01alpha ------------------------------------------------------------------------------------------------------------------------------------------------------------------- 767.18s
kustomize_deploy : Run Wait Conditions for examples/dt/uni01alpha/networker --------------------------------------------------------------------------------------------------------------------------------------------------------- 461.64s
kustomize_deploy : Run Wait Conditions for examples/dt/uni01alpha/control-plane ----------------------------------------------------------------------------------------------------------------------------------------------------- 327.05s
os_must_gather : Run openstack-must-gather command ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 170.76s
ci_setup : Install needed packages --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 53.62s
openshift_obs : Wait for observability-operator pod ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 50.60s
kustomize_deploy : Wait for cert-manager-operator pods ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 40.60s
kustomize_deploy : Wait for MetalLB speaker pods ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 35.65s
kustomize_deploy : Wait for certmanager pods ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 25.59s
repo_setup : Make sure git-core package is installed --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 24.04s
kustomize_deploy : Wait for NMstate handler pods ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 20.57s
artifacts : Ensure we have proper rights on the gathered content --------------------------------------------------------------------------------------------------------------------------------------------------------------------- 17.94s
kustomize_deploy : Wait for NMstate webhook deployment ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 10.72s
kustomize_deploy : Wait for cainjector pods ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 10.55s
kustomize_deploy : Run Wait Conditions for examples/dt/uni01alpha/control-plane/nncp -------------------------------------------------------------------------------------------------------------------------------------------------- 6.95s
kustomize_deploy : Wait for webhook pods ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 5.54s
ci_local_storage : Fetch hostnames for all hosts -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 5.38s
repo_setup : Generate repos using rhos-release ceph-7.0-rhel-9 -r 9.3 ----------------------------------------------------------------------------------------------------------------------------------------------------------------- 4.66s
ci_local_storage : Perform action in the PV directory --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 3.93s
ci_local_storage : Perform action in the PV directory --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 3.82s

Openshift logs

$ oc get openstackcontrolplane
NAME           STATUS   MESSAGE
controlplane   True     Setup complete

$ oc get openstackdataplanedeployment
NAME               NODESETS              STATUS   MESSAGE
edpm-deployment    ["openstack-edpm"]    True     Setup complete
networker-deploy   ["networker-nodes"]   True     Setup complete

$ oc get openstackdataplanenodesets
NAME              STATUS   MESSAGE
networker-nodes   True     NodeSet Ready
openstack-edpm    True     NodeSet Ready

ASBishop
ASBishop reviewed Feb 2, 2024
View reviewed changes
dt/unified/alpha/kustomization.yaml Outdated Show resolved Hide resolved
examples/dt/unified/alpha/README.md Outdated Show resolved Hide resolved
examples/dt/unified/alpha/README.md Outdated Show resolved Hide resolved
examples/dt/unified/alpha/README.md Outdated Show resolved Hide resolved
examples/dt/unified/alpha/README.md Outdated Show resolved Hide resolved
examples/dt/unified/alpha/service-values.yaml Outdated Show resolved Hide resolved
examples/dt/unified/alpha/service-values.yaml Outdated Show resolved Hide resolved
@psathyan psathyan force-pushed the uniAlpha branch 2 times, most recently from 2ec69dd to 0124b5d Compare February 7, 2024 15:26
@psathyan psathyan changed the title CRs for unified alpha deployed topology CRs for uni01alpha deployed topology Feb 17, 2024
@psathyan psathyan force-pushed the uniAlpha branch 2 times, most recently from 9715bc1 to a071606 Compare February 17, 2024 14:47
@psathyan psathyan force-pushed the uniAlpha branch 8 times, most recently from 2ffe65c to d34a69d Compare March 17, 2024 09:09
ASBishop
ASBishop requested changes Mar 18, 2024
View reviewed changes
examples/dt/uni-alpha/README.md Outdated Show resolved Hide resolved
examples/dt/uni-alpha/control-plane/service-values.yaml Outdated Show resolved Hide resolved
examples/dt/uni-alpha/control-plane/service-values.yaml Outdated Show resolved Hide resolved
dt/uni-alpha/kustomization.yaml Outdated Show resolved Hide resolved
@psathyan
Copy link
Contributor Author

@ASBishop thank you for taking the time to review, provide feedback and suggest the right changes.

Ack, will correct them shortly.

psathyan
psathyan commented Mar 20, 2024
View reviewed changes
Copy link
Contributor Author

@psathyan psathyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from @karelyatin and @bharathmv13

examples/dt/uni-alpha/networker/values.yaml Outdated Show resolved Hide resolved
examples/dt/uni-alpha/networker/values.yaml Outdated Show resolved Hide resolved
examples/dt/uni-alpha/control-plane/service-values.yaml Outdated Show resolved Hide resolved
examples/dt/uni-alpha/values.yaml Outdated Show resolved Hide resolved
examples/dt/uni-alpha/control-plane/nncp/values.yaml Outdated Show resolved Hide resolved
@psathyan psathyan force-pushed the uniAlpha branch 6 times, most recently from a2d9f43 to 20b8323 Compare March 28, 2024 05:06
@psathyan psathyan force-pushed the uniAlpha branch 2 times, most recently from 9832c9b to 8b99073 Compare March 28, 2024 12:06
afazekas added a commit that referenced this pull request Apr 18, 2024
@afazekas
uni06zeta initial version
2543b30 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
afazekas added a commit that referenced this pull request Apr 18, 2024
@afazekas
uni06zeta initial version
c7a3b8f 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
afazekas added a commit that referenced this pull request Apr 18, 2024
@afazekas
uni06zeta initial version
c4abfe7 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
@psathyan psathyan force-pushed the uniAlpha branch 2 times, most recently from 691670b to cc57222 Compare April 18, 2024 10:05
abays
abays approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this now. Let's see what @ASBishop thinks, since he was requesting changes.

/lgtm

karelyatin
karelyatin reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

automation/vars/uni01alpha.yaml Outdated Show resolved Hide resolved
karelyatin
karelyatin reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

afazekas added a commit that referenced this pull request Apr 18, 2024
@afazekas
uni06zeta initial version
36db2eb 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
ASBishop
ASBishop approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ASBishop ASBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me

fultonj
fultonj reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think we should merge this soon.

I'd like it if Andrew's recent comment about lib/control-plane/kustomization.yaml could be addressed before merging.

#83 (comment)

While you're at it I'm hoping you can fix the path in the readme I pointed out.

Also, it would be nice to patch ci-framework/README.md with a link to uniAlpha/examples/dt/uni01alpha/README.md, but we don't have to block on that.

Thanks

@fultonj fultonj mentioned this pull request Apr 18, 2024
Merged
@sdatko sdatko mentioned this pull request Apr 18, 2024
Merged
@psathyan psathyan force-pushed the uniAlpha branch 2 times, most recently from 2e27293 to a06a444 Compare April 19, 2024 05:39
afazekas added a commit that referenced this pull request Apr 19, 2024
@afazekas
uni06zeta initial version
bfb99b8 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
afazekas added a commit that referenced this pull request Apr 19, 2024
@afazekas
uni06zeta initial version
2b7dd18 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
afazekas added a commit that referenced this pull request Apr 19, 2024
@afazekas
uni06zeta initial version
9209cb1 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
afazekas added a commit that referenced this pull request Apr 19, 2024
@afazekas
uni06zeta initial version
cbd36d4 
This is based on other peding changes referenced below.
Line-length warning limit extended some config lines are really long,
and less readable when wrapped.

https://github.com/openstack-k8s-operators/architecture/pull/73/files#diff-2b848ad66a53ba3c4f0a6111d518dcf85c4995f7299ee657c76c1a95a0058ebe
184193a
#83
@psathyan
CRs for uni-alpha
ac8bb7d 
Signed-off-by: Pragadeeswaran Sathyanarayanan <[email protected]>
abays
abays approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fultonj fultonj merged commit d0cc2ea into openstack-k8s-operators:main Apr 19, 2024
4 checks passed
@psathyan psathyan mentioned this pull request Apr 21, 2024
Closed
3 tasks
@psathyan psathyan deleted the uniAlpha branch April 23, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximsava12 maximsava12 maximsava12 left review comments

@rsafrono rsafrono rsafrono left review comments

@cjeanner cjeanner cjeanner left review comments

@sdatko sdatko sdatko left review comments

@karelyatin karelyatin karelyatin left review comments

@vyzigold vyzigold vyzigold left review comments

@beagles beagles beagles left review comments

@fultonj fultonj fultonj left review comments

@jlarriba jlarriba jlarriba left review comments

@ASBishop ASBishop ASBishop approved these changes

@abays abays abays approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.