Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first BGP DTs - WIP #44

Closed
wants to merge 5 commits into from
Closed

Add first BGP DTs - WIP #44

wants to merge 5 commits into from

Conversation

eduolivares
Copy link
Contributor

First BGP DT including the following characteristics:

  • Virtualized environment: all nodes and routers are VMs running on a HV, connected through virtual networks.
  • DVR: FIP's traffic distributed, using Networker nodes for centralized SNAT traffic.
  • Spine/Leaf setup: Openstack and Openshift nodes connected between them through spine/leaf routers.
  • ExtVM and ExtRouter required to test dataplane connectivity from the Internet (from a different ASN).
  • Tempest neutron and octavia scenario tests.
  • Tobiko faults workflow: sanity, create-resources, faults (HA), sanity, verify-resources.

@eduolivares eduolivares changed the title Add first BPG DT Add first BPG DTs Jan 12, 2024
@eduolivares eduolivares changed the title Add first BPG DTs Add first BPG DTs - WIP Jan 12, 2024
@eduolivares eduolivares changed the title Add first BPG DTs - WIP Add first BGP DTs - WIP Jan 29, 2024
@eduolivares eduolivares force-pushed the bgp_dts branch 16 times, most recently from 98f6ea2 to 7659e25 Compare April 9, 2024 15:24
@eduolivares eduolivares force-pushed the bgp_dts branch 11 times, most recently from 1b895c9 to 86d6e51 Compare April 16, 2024 08:11
@eduolivares eduolivares force-pushed the bgp_dts branch 6 times, most recently from abcda53 to 2295f26 Compare April 19, 2024 13:30
@eduolivares
BGP DTs
138acdc 
Includes examples/dt/bgp/common/control-plane/nncp/

Configuration 1 (kernel-routing-nbdb-driver):
- BGP
- Ceph and Networker nodes
- DVR
- expose-tenant-networks disabled
- default sync-interval
- kernel routing
- NBDB driver
- FRR: interface-level BGP peers
- FRR: different ASN per rack
- Tempest (neutron+octavia) + Tobiko (scenario+sanity+faults)

Configuration 2 (ovn-routing-nbdb-driver):
- BGP
- Networker nodes
- DVR
- expose-tenant-networks enabled
- sync-interval configured with high value
- OVN routing
- NBDB driver
- FRR: IP-level BGP peers
- FRR: different ASN per rack
- Tempest (neutron+octavia) + Tobiko (scenario+sanity+faults)

Configuration 3 (ovn-routing-nbdb-driver-nondvr):
- BGP
- Networker nodes
- DVR disabled
- expose-tenant-networks enabled
- default sync-interval
- OVN routing
- NBDB driver
- FRR: IP-level BGP peers
- FRR: different ASN per rack
- Tempest (neutron+octavia) + Tobiko (scenario+sanity+faults)

Configuration 4 (kernel-routing-sbdb-driver-ipv6):
- BGP
- Networker nodes
- IPv6 single-stack controlplane
- DVR
- expose-tenant-networks disabled
- default sync-interval
- kernel routing
- SBDB driver
- FRR: IP-level BGP peers
- FRR: different ASN per rack
- Tempest (neutron+octavia) + Tobiko (scenario+sanity+faults)

BGP dataplane

fixing controlplane and dataplane stuff

bgp - disable octavia until it is fixed

swift
@eduolivares
bgp - refactor nncp
614c4e0
@eduolivares
bgp - refactor controlplane
961e384
@eduolivares
fix yamllint
b082646
@eduolivares
fix NAD
66d0300
@fultonj
Copy link
Contributor

fultonj commented Apr 29, 2024

Is this obsoleted by #193 ?

@fultonj fultonj added needs-info Information is requested of the reporter or reviewers deployment-topology Deployment topology changes or implementations labels Apr 29, 2024
@eduolivares
Copy link
Contributor Author

Is this obsoleted by #193 ?

There is something in this PR that has not been implemented in #193. The four README.md files describe the 4 BGP DTs we want to finally covered, after #193 is merged.
Maybe it will be more clean to close #44 and open a new one when I start working on those DTs.

@leifmadsen
Copy link
Contributor

Is this obsoleted by #193 ?

There is something in this PR that has not been implemented in #193. The four README.md files describe the 4 BGP DTs we want to finally covered, after #193 is merged. Maybe it will be more clean to close #44 and open a new one when I start working on those DTs.

I don't believe we plan to merge README-only PRs at this time, and would expect code implementation along with the DT READMEs. It might be best to open separate Jira trackers for the DTs that are planned for implementation, and then show up with PRs once the work is ready to move forward, rather than having long-opened PRs that are missing the implementation.

@eduolivares
Copy link
Contributor Author

Is this obsoleted by #193 ?

There is something in this PR that has not been implemented in #193. The four README.md files describe the 4 BGP DTs we want to finally covered, after #193 is merged. Maybe it will be more clean to close #44 and open a new one when I start working on those DTs.

I don't believe we plan to merge README-only PRs at this time, and would expect code implementation along with the DT READMEs. It might be best to open separate Jira trackers for the DTs that are planned for implementation, and then show up with PRs once the work is ready to move forward, rather than having long-opened PRs that are missing the implementation.

That sounds reasonable to me (sorry for the late reply). Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosky tosky tosky left review comments

Assignees
No one assigned
Labels
deployment-topology Deployment topology changes or implementations needs-info Information is requested of the reporter or reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eduolivares @fultonj @leifmadsen @tosky