Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trigger-downstream-job github workflow #393

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add trigger-downstream-job github workflow #393

merged 1 commit into from
Sep 11, 2024
+9 −0

Conversation

raukadah
Copy link
Contributor

By enabling trigger-downstream-job workflow, trigger github-experimental comment will be triggered by approvers only (defined in the owners file).

It will help us to avoid misue of trigger functionality.

The same[1] is already added in ci-framework repo.

Links:
[1]. openstack-k8s-operators/ci-framework#2324

@raukadah
Copy link
Contributor Author

/test unit

1 similar comment
@raukadah
Copy link
Contributor Author

/test unit

@raukadah raukadah force-pushed the trigger_job branch 2 times, most recently from c781d9c to b115f34 Compare September 11, 2024 01:20
cjeanner
cjeanner approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@cjeanner cjeanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a327bab712444d238ee97eb644dca79d

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@cjeanner
Copy link
Contributor

recheck

@cjeanner
Copy link
Contributor

recheck github-gate

abays
abays approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8cf8618d8d3c4bfa8adc2a2c9ba4acb2

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@abays
Copy link
Contributor

abays commented Sep 11, 2024

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

I tried rebasing this PR and then force-pushing. It did nothing:

$ git pull --rebase upstream main
From https://github.com/openstack-k8s-operators/architecture
 * branch            main       -> FETCH_HEAD
 * [new branch]      main       -> upstream/main
Current branch trigger_job is up to date.

$ git push -f
Everything up-to-date

@raukadah
Copy link
Contributor Author

recheck-gate

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bcb8c2cc44704e46bf45668b8698a191

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@openshift-ci openshift-ci bot removed the lgtm label Sep 11, 2024
@cjeanner
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a08211d0e684469fad80ed1ad1cd4b2d

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

abays
abays approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d690a5330a954c7c9a1c075167925882

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@raukadah
Add trigger-downstream-job github workflow
ffe57e6 
By enabling trigger-downstream-job workflow, `trigger
github-experimental` comment will be triggered by approvers only
(defined in the owners file).

It will help us to avoid misue of trigger functionality.

The same[1] is already added in ci-framework repo.

Links:
[1]. openstack-k8s-operators/ci-framework#2324

Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Sep 11, 2024
@cjeanner
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, cjeanner, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abays,cjeanner,raukadah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raukadah
Copy link
Contributor Author

recheck-gate

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e83423b29996454ca78d54e2f28dafef

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@cjeanner cjeanner merged commit 538ac02 into openstack-k8s-operators:main Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@cjeanner cjeanner cjeanner approved these changes

Assignees

@abays abays

@cjeanner cjeanner

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raukadah @cjeanner @abays