Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CI validation: ensure files exist #164

Merged

Conversation

cjeanner
Copy link
Contributor

@cjeanner cjeanner commented Apr 4, 2024

Since we now ensure the automation schema is valid, we also want to
ensure linked directories and files exist in the various automation
scenarios.

This new script will load any YAML file nested in the automation/vars
directory, and ensures all the path and src_file are present.

@cjeanner cjeanner force-pushed the automation/validate-files branch 2 times, most recently from a3011bf to fa603e8 Compare April 4, 2024 19:33
Since we now ensure the automation schema is valid, we also want to
ensure linked directories and files exist in the various automation
scenarios.

This new script will load any YAML file nested in the automation/vars
directory, and ensures all the `path` and `src_file` are present.
@cjeanner
Copy link
Contributor Author

cjeanner commented Apr 4, 2024

@abays any thoughts on that one?

I have just a small "maybe..." related to the amount of github actions we're allowed to run, either per repository or in the organzation: maybe I should get everything in one action, stacking the steps? It would make the output slightly "uglier", but we'd be able to spare on github limits... ?

@cjeanner cjeanner marked this pull request as ready for review April 4, 2024 23:47
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a go for now

/lgtm

@abays abays merged commit 25198d1 into openstack-k8s-operators:main Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants