Add duplicate ZEIR ID cleanup job #168
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ekigamba
commented
Jan 13, 2023
ekigamba
commented
- Fixes https://github.com/opensrp/support/issues/278
|
Depends on this PR in client core opensrp/opensrp-client-core#902 |
ekigamba
commented
Feb 17, 2023
| @@ -371,7 +381,9 @@ dependencies { | |||
| // Because RxAndroid releases are few and far between, it is recommended you also | |||
| // explicitly depend on RxJava's latest version for bug fixes and new features. | |||
| implementation 'io.reactivex.rxjava2:rxjava:2.2.19' | |||
| implementation 'com.evernote:android-job:1.2.6' | |||
| implementation('com.github.devv911:android-job:1.4.5') { | |||
There was a problem hiding this comment.
Create an issue to remove this and either update the client-core version or use an official version from evernote-job
There was a problem hiding this comment.
created issue for it https://github.com/opensrp/support/issues/298
There was a problem hiding this comment.
I think the issue should be to remove this dependency with an official one or use client-core v6
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
Let's exclude this from the PR and add it to gitignore
…tps://github.com/opensrp/opensrp-client-unicef-tunisia into issue/support/278-fix-duplicate-zeir-ids-tunisia
Add F_ZEIR_ID to duplicate IDs fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.