Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary multi-threading #665

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removing unnecessary multi-threading #665

wants to merge 3 commits into from

Conversation

hamza-vd
Copy link
Contributor

@hamza-vd hamza-vd commented Aug 4, 2023

Remove unnecessary multi-threading in order to avoid relevance issues

@hamza-vd hamza-vd marked this pull request as ready for review August 7, 2023 06:12
@hamza-vd hamza-vd force-pushed the remove-unnecessary-threading branch from 1a6a71c to c799ee1 Compare August 7, 2023 07:20
SebaMutuku
SebaMutuku reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@SebaMutuku SebaMutuku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any effect on refresh? Is it possible to move the initial logic to run on UI thread instead of using Disk.io()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebaMutuku SebaMutuku SebaMutuku left review comments

@junaidwarsivd junaidwarsivd Awaiting requested review from junaidwarsivd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza-vd @SebaMutuku @hilpitome