Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BA form performance triage and improvement #1805

Open
wants to merge 16 commits into
base: master-v1
Choose a base branch
from
Open

BA form performance triage and improvement #1805

wants to merge 16 commits into from

Conversation

hilpitome
Copy link

Fixes issue #1797

  • Check if app is syncing before executing ChwScheduleTaskExecutor
  • Upgraded native forms to the current version(v2.0.8-SNAPSHOT)

@hilpitome hilpitome changed the base branch from master to master-v1 June 24, 2021 12:23
ndegwamartin
ndegwamartin reviewed Jul 15, 2021
View reviewed changes
opensrp-chw/src/main/java/org/smartregister/chw/activity/AncHomeVisitActivity.java
@@ -32,7 +32,7 @@
public static void startMe(Activity activity, String baseEntityID, Boolean isEditMode) {
Intent intent = new Intent(activity, AncHomeVisitActivity.class);
intent.putExtra(org.smartregister.chw.anc.util.Constants.ANC_MEMBER_OBJECTS.BASE_ENTITY_ID, baseEntityID);
intent.putExtra(org.smartregister.chw.anc.util.Constants.ANC_MEMBER_OBJECTS.EDIT_MODE, isEditMode);
intent.putExtra(org.smartregister.chw.anc.util.Constants.ANC_MEMBER_OBJECTS.EDIT_MODE, isEditMode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space

allan-on
allan-on requested changes Jul 17, 2021
View reviewed changes
opensrp-chw/google-services.json
@@ -0,0 +1,591 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we commit the Google Services JSON file. This should be ignored in .gitignore

@allan-on
Copy link
Collaborator

allan-on commented Aug 6, 2021 •
edited by hilpitome
Loading

@hilpitome Can this PR's title have a description instead of the issue number?
That will make it easier to find it in future when scanning through the list of PRs
@allan-on noted

@hilpitome hilpitome changed the title Issue1797 BA form performance triage and improvement Sep 10, 2021
@ekigamba ekigamba mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegwamartin ndegwamartin ndegwamartin left review comments

@allan-on allan-on allan-on requested changes

@qiarie qiarie Awaiting requested review from qiarie

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hilpitome @allan-on @ndegwamartin