optimize performance by removing unnecessary logs #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is based on the task https://github.com/onaio/opensrp-tasks/issues/152 |
dubdabasoduba
requested changes
Oct 30, 2022
Comment on lines
+25
to
+40
| } | ||
| -assumenosideeffects class android.util.Log { | ||
| public static boolean isLoggable(java.lang.String, int); | ||
| public static int v(...); | ||
| public static int d(...); | ||
| public static int i(...); | ||
| public static int w(...); | ||
| public static int e(...); | ||
| } | ||
|
|
||
| -assumenosideeffects class timber.log.Timber* { | ||
| public static *** v(...); | ||
| public static *** d(...); | ||
| public static *** i(...); | ||
| public static int w(...); | ||
| public static int e(...); |
There was a problem hiding this comment.
Do we have a better way to do this without repetition?
There was a problem hiding this comment.
I followed the guide here https://github.com/onaio/opensrp-tasks/issues/152
ndegwamartin
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.