Adding the translatable text attribute to several widgets #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attention Flags issue fix done
PDF naming fix added
Develop subforms issue
…d_translation_strings
dubdabasoduba
commented
Jun 16, 2022
opensrp-anc/build.gradle
Outdated
| @@ -178,7 +178,7 @@ tasks.withType(Test) { | |||
|
|
|||
| dependencies { | |||
| implementation 'androidx.appcompat:appcompat:1.3.1' | |||
| implementation('org.smartregister:opensrp-client-native-form:2.1.17-SNAPSHOT@aar') { | |||
| implementation('org.smartregister:opensrp-client-native-form:2.1.18-PREVIEW-SNAPSHOT@aar') { | |||
There was a problem hiding this comment.
Please publish the library from master
opensrp-anc/build.gradle
Outdated
| @@ -189,7 +189,7 @@ dependencies { | |||
| exclude group: 'org.yaml', module: 'snakeyaml' | |||
| exclude group: 'io.ona.rdt-capture', module: 'lib' | |||
| } | |||
| implementation('org.smartregister:opensrp-client-core:4.3.26-SNAPSHOT@aar') { | |||
| implementation('org.smartregister:opensrp-client-core:5.0.3-PREVIEW-SNAPSHOT@aar') { | |||
There was a problem hiding this comment.
Please publish the library from master
Comment on lines
110
to
114
| if(isPermissionGranted()) | ||
| { | ||
| loadContactSummaryData(); | ||
| } | ||
| else if(!isPermissionGranted() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) |
There was a problem hiding this comment.
What Permission is this?
Comment on lines
+382
to
384
| public void createContactSummaryPdf(String womanName) { | ||
| //overridden | ||
| } |
There was a problem hiding this comment.
Any reason we are not implementing this?
| facts.put(key, value); | ||
| } else { | ||
| facts.put(key, ""); | ||
| facts.put(key, ValueObject); |
reference-app/build.gradle
Outdated
| @@ -230,7 +230,7 @@ dependencies { | |||
| coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:1.1.5' | |||
| def powerMockVersion = '2.0.7' | |||
| implementation project(":opensrp-anc") | |||
| implementation('org.smartregister:opensrp-client-native-form:2.1.17-SNAPSHOT@aar') { | |||
| implementation('org.smartregister:opensrp-client-native-form:2.1.18-PREVIEW-SNAPSHOT@aar') { | |||
There was a problem hiding this comment.
Publish the libraries from master
reference-app/build.gradle
Outdated
| @@ -242,7 +242,7 @@ dependencies { | |||
| exclude group: 'io.ona.rdt-capture', module: 'lib' | |||
| } | |||
|
|
|||
| implementation('org.smartregister:opensrp-client-core:4.3.26-SNAPSHOT@aar') { | |||
| implementation('org.smartregister:opensrp-client-core:5.0.3-PREVIEW-SNAPSHOT@aar') { | |||
There was a problem hiding this comment.
Publish the libraries from master
Search by alt name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.