-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed map search #3491
base: main
Are you sure you want to change the base?
fixed map search #3491
Changes from 6 commits
56a90eb
4071283
54adbba
0b9f5f3
e05b2c5
566ace9
80d4f8e
eb3867f
194bdfd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<resources> | ||
<string name="no_found_locations_matching_text">No caregiver found matching text \"%1$s\"</string> | ||
</resources> | ||
Comment on lines
+1
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Close this PR and create a new PR pointing to the main branch with this change in gizEir build variant. @f-odhiambo There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ellykits I might be wrong but this is on the gizEir strings.xml. I think it's fine there |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -180,13 +180,12 @@ class GeoWidgetLauncherFragment : Fragment(), OnSyncListener { | |
geoWidgetConfig = geoWidgetConfiguration, | ||
searchText = searchText, | ||
) | ||
if (geoJsonFeatures.isNotEmpty()) { | ||
geoWidgetViewModel.features.postValue(geoJsonFeatures) | ||
} else { | ||
geoWidgetViewModel.features.postValue(geoJsonFeatures) | ||
if (geoJsonFeatures.isEmpty()) { | ||
geoWidgetLauncherViewModel.emitSnackBarState( | ||
SnackBarMessageConfig( | ||
message = | ||
getString(R.string.no_found_locations_matching_text, searchText), | ||
getString(R.string.no_found_locations_matching_text, searchText), | ||
), | ||
) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This condition has just been inverted. Not necessary. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @owais-vd @syedowaisali please look into this. |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation was refactored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would no longer be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #3488