Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test single transaction save for questionnaires #3449

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Aug 16, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS added the DNM DO NOT MERGE label Aug 16, 2024
@LZRS LZRS self-assigned this Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.5%. Comparing base (490c294) to head (deb1cfd).
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3449     +/-   ##
=========================================
+ Coverage     27.0%   27.5%   +0.4%     
+ Complexity     720     719      -1     
=========================================
  Files          269     270      +1     
  Lines        13517   13370    -147     
  Branches      2433    2397     -36     
=========================================
+ Hits          3662    3680     +18     
+ Misses        9373    9205    -168     
- Partials       482     485      +3     
Flag Coverage Δ
engine 64.6% <ø> (+<0.1%) ⬆️
geowidget 11.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 2.6% <ø> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant