Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout code: detecting code styling / formatting issues #14

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
0cd273e
bgp: Using variable after free
RodrigoMNardi Jun 26, 2023
f0bfb32
bgp: Using variable after free
RodrigoMNardi Jun 26, 2023
01fcb57
doc: long line
RodrigoMNardi Oct 12, 2023
0a2b1d3
doc: long line
RodrigoMNardi Oct 12, 2023
bb237d3
doc: updating README.md
RodrigoMNardi Oct 16, 2023
b8562af
doc: updating README.md
RodrigoMNardi Nov 6, 2023
704f070
doc: updating README.md
RodrigoMNardi Nov 6, 2023
9e3ff7c
doc: updating README.md
RodrigoMNardi Nov 6, 2023
97eda27
doc: updating README.md
RodrigoMNardi Nov 7, 2023
386b8bd
doc: updating README.md
RodrigoMNardi Nov 7, 2023
9ef355b
doc: updating README.md
RodrigoMNardi Nov 7, 2023
f49c317
doc: updating README.md
RodrigoMNardi Nov 7, 2023
b58258d
doc: updating README.md
RodrigoMNardi Nov 7, 2023
f2507e2
doc: updating README.md
RodrigoMNardi Nov 7, 2023
464b181
doc: updating README.md
RodrigoMNardi Nov 7, 2023
f1d04b5
doc: updating README.md
RodrigoMNardi Nov 8, 2023
b766e13
doc: updating README.md
RodrigoMNardi Nov 8, 2023
4628591
doc: updating README.md
RodrigoMNardi Nov 8, 2023
3a1ffc1
doc: updating README.md
RodrigoMNardi Nov 8, 2023
ecdd124
doc: updating README.md
RodrigoMNardi Nov 8, 2023
31482d2
doc: updating README.md
RodrigoMNardi Nov 9, 2023
fbeeede
doc: updating README.md
RodrigoMNardi Nov 9, 2023
c6cbd0e
doc: updating README.md
RodrigoMNardi Nov 9, 2023
d7e991a
doc: updating README.md
RodrigoMNardi Nov 10, 2023
cdb1be5
doc: updating README.md
RodrigoMNardi Nov 10, 2023
109ff2e
doc: updating README.md
RodrigoMNardi Nov 10, 2023
adad4d6
doc: updating README.md
RodrigoMNardi Nov 13, 2023
7b9a60f
doc: updating README.md
RodrigoMNardi Nov 21, 2023
e74cb8a
doc: updating README.md
RodrigoMNardi Nov 23, 2023
d4d5665
doc: updating README.md
RodrigoMNardi Nov 24, 2023
d7ce1cb
doc: updating README.md
RodrigoMNardi Dec 14, 2023
df07513
doc: updating README.md
RodrigoMNardi Dec 14, 2023
1933e2a
doc: updating README.md
RodrigoMNardi Dec 18, 2023
5d719ae
doc: updating README.md
RodrigoMNardi Dec 18, 2023
74d2f0a
doc: updating README.md
RodrigoMNardi Dec 18, 2023
259e4a9
doc: updating README.md
RodrigoMNardi Mar 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bgpd/bgp_bfd.c
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ static void bgp_peer_remove_bfd(struct peer *p)
}

if (p->bfd_config)
bfd_sess_free(&p->bfd_config->session);
bfd_sess_free(&p->bfd_config->session);

XFREE(MTYPE_BFD_CONFIG, p->bfd_config);
}
Expand Down
21 changes: 6 additions & 15 deletions ospfd/ospf_ase.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,7 @@ struct ospf_route *ospf_find_asbr_route(struct ospf *ospf,
best = or ;
else if (best->cost ==
or->cost
&& IPV4_ADDR_CMP(
&best->u.std.area_id,
& or->u.std.area_id)
< 0)
&& IPV4_ADDR_CMP(&best->u.std.area_id,& or->u.std.area_id) < 0)
best = or ;
}

Expand All @@ -88,9 +85,7 @@ struct ospf_route *ospf_find_asbr_route(struct ospf *ospf,
return best;
}

struct ospf_route *ospf_find_asbr_route_through_area(struct route_table *rtrs,
struct prefix_ipv4 *asbr,
struct ospf_area *area)
struct ospf_route *ospf_find_asbr_route_through_area(struct route_table *rtrs, struct prefix_ipv4 *asbr, struct ospf_area *area)
{
struct route_node *rn;

Expand Down Expand Up @@ -320,8 +315,7 @@ int ospf_ase_calculate_route(struct ospf *ospf, struct ospf_lsa *lsa)

if (rn == NULL || (asbr_route = rn->info) == NULL) {
if (IS_DEBUG_OSPF(lsa, LSA))
zlog_debug(
"Route[External]: Can't find route to forwarding address");
zlog_debug("Route[External]: Can't find route to forwarding address");
if (rn)
route_unlock_node(rn);
return 0;
Expand Down Expand Up @@ -443,8 +437,7 @@ int ospf_ase_calculate_route(struct ospf *ospf, struct ospf_lsa *lsa)
zlog_debug("Route[External]: Routes are equal");
ospf_route_copy_nexthops(or, asbr_route->paths);
if (al->e[0].fwd_addr.s_addr != INADDR_ANY)
ospf_ase_complete_direct_routes(
or, al->e[0].fwd_addr);
ospf_ase_complete_direct_routes(or, al->e[0].fwd_addr);
}
}
/* Make sure setting newly calculated ASBR route.*/
Expand Down Expand Up @@ -533,8 +526,7 @@ static int ospf_ase_compare_tables(struct ospf *ospf,
if ((or = rn->info)) {
if (!(new_rn = route_node_lookup(new_external_route,
&rn->p)))
ospf_zebra_delete(
ospf, (struct prefix_ipv4 *)&rn->p, or);
ospf_zebra_delete(ospf, (struct prefix_ipv4 *)&rn->p, or);
else
route_unlock_node(new_rn);
}
Expand Down Expand Up @@ -581,8 +573,7 @@ static void ospf_ase_calculate_timer(struct event *t)

if (area->external_routing == OSPF_AREA_NSSA)
LSDB_LOOP (NSSA_LSDB(area), rn, lsa)
ospf_ase_calculate_route(ospf,
lsa);
ospf_ase_calculate_route(ospf, lsa);
}
/* kevinm: And add the NSSA routes in ospf_top */
LSDB_LOOP (NSSA_LSDB(ospf), rn, lsa)
Expand Down
Loading