Draft pr #436
commitlint.yml
on: pull_request
Check if the commits meet the requirements of the guidelines
27s
Annotations
1 error and 1 warning
Check if the commits meet the requirements of the guidelines
You have commit messages with errors
⧗ input: lib, bgpd, nhrpd: Cleanup memory in lib/resolver on shutdown
This memory was not being cleaned up on shutdown. Fix this.
Signed-off-by: Donald Sharp <[email protected]>
✖ type may not be empty [type-empty]
✖ subject may not be empty [subject-empty]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: bgpd, lib: add zapi_route_set_nhg_id() support
There is no function that both sets the nhg id, and sets
the ZAPI_MESSAGE_NHG flag if the nhg id is valid.
Create a ZAPI API to do this, and apply the changes wherever
needed.
Signed-off-by: Philippe Guibert <[email protected]>
✖ type may not be empty [type-empty]
✖ subject may not be empty [subject-empty]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: zebra: Show IPv6 link-local interfaces under `show interface brief` output
Despite if it's managed by FRR or the kernel, show it. If the system has only
link-local addresses, we should show it unless it's a secondary one.
Signed-off-by: Donatas Abraitis <[email protected]>
✖ header must not be longer than 72 characters, current length is 74 [header-max-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: redhat: rpm spec: added protobuf-c to deps & fix bogus changelog date
Fixes for:
```
checking for protoc-c... no
configure: error: in `/builddir/build/BUILD/frr-frr-9.1':
configure: error: protobuf requested but protoc-c not found. Install protobuf-c.
```
And rpmlint warnings:
```
warning: line 208: It's not recommended to have unversioned Obsoletes: Obsoletes: gated mrt zebra frr-sysvinit
warning: bogus date in %changelog: Thu Oct 09 2023 Donatas Abraitis <[email protected]> - 9.1
line 208: It's not recommended to have unversioned Obsoletes: Obsoletes: gated mrt zebra frr-sysvinit
bogus date in %changelog: Thu Oct 09 2023 Donatas Abraitis <[email protected]> - 9.1
```
Signed-off-by: Konstantin Shalygin <[email protected]>
✖ type must be one of [babeld, bfdd, bgpd, build, doc, docker, eigrpd, fpm, isisd, ldpd, lib, mgmtd, multi, nhrpd, ospf6d, ospfd, pathd, pbrd, pimd, pim6d, ripd, ripngd, sharpd, staticd, tests, tools, vtysh, vrrpd, yang, zebra, all] [type-enum]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: github: Mark the build as failed if 'do not merge' label is set
This prevents us from merging PRs marked as 'do not merge'.
Signed-off-by: Donatas Abraitis <[email protected]>
✖ type must be one of [babeld, bfdd, bgpd, build, doc, docker, eigrpd, fpm, isisd, ldpd, lib, mgmtd, multi, nhrpd, ospf6d, ospfd, pathd, pbrd, pimd, pim6d, ripd, ripngd, sharpd, staticd, tests, tools, vtysh, vrrpd, yang, zebra, all] [type-enum]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: doc: add diagram of oper-state queries.
Signed-off-by: Christian Hopps <[email protected]>
✖ subject may not end with full stop [subject-full-stop]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: *: Remove Crypto openSSL define from zebra.h
Only a couple of places use this. Move these to a better
spot.
Signed-off-by: Donald Sharp <[email protected]>
✖ type may not be empty [type-empty]
✖ subject may not be empty [subject-empty]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: lib: Move some priviledge headers to file they are used.
Signed-off-by: Donald Sharp <[email protected]>
✖ subject may not end with full stop [subject-full-stop]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-change
|
Check if the commits meet the requirements of the guidelines
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|