Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSHMEM 1.6rc1 Draft #540

Merged
merged 91 commits into from
Sep 27, 2024
Merged

OpenSHMEM 1.6rc1 Draft #540

merged 91 commits into from
Sep 27, 2024

Conversation

jdinan
Copy link
Collaborator

@jdinan jdinan commented Sep 6, 2024 •
edited
Loading

stewartl318 and others added 30 commits August 22, 2024 09:24
@stewartl318
remove duplicate text
bbe5c9c
@wrrobin
Minor updates to the text
560dc19
@isubsmith @wrrobin
tweak to wording for shmem_init for repeatable calls
3cb46cf
@isubsmith @wrrobin
Tweaks to the discussion of implicit barriers in shmem_malloc/shmem_m…
bdd5da0 
…alloc_hints
@ronawho
Clean up and flesh out AMO section of overview list
74148b3 
Add atomic fetch/swap to the list, make it clear CAS is conditional, and
unify some language ("a PE" -> "the PE", "returns with" -> "returns",
"that symmetric data" -> "the symmetric data")
@ronawho
Clean up and add new routines to collective section of the overview list
6d0655b 
Add scan, avoid active set language, don't say broadcast avoids copying
to self since the teams based version does do that.
@ronawho
Note allocation routines are collective in overview list
17b6eee 
This makes the collective nature more explicit to match language in the
allocation section.
@ronawho
Clean up and add new routines to the signaling section of the overvie…
68b4caf 
…w list

Update put signal to match the language of a regular put more closely
and add signal set/add/fetch.
@ronawho
Add sessions to overview list
83d8bd6
@ronawho
Add shmem_team_ptr to memory model text about getting local pointer
b2e6300
@ronawho
Update atomic example 3 to avoid deprecated active-set collective
91658e8 
Switch example 3 from `shmem_int_sum_to_all` to `shmem_int_sum_reduce`
since the former is deprecated.
@ronawho
Add session constants to the library constant table
8427195 
Add `SHMEM_CTX_SESSION_TOTAL_OPS` and `SHMEM_CTX_SESSION_BATCH` to the
library constant table (text based `SHMEM_TEAM_NUM_CONTEXTS` and
`SHMEM_CTX_NOSTORE` respectively since they have similar uses)
@wrrobin
PR 514 content: signal set add update
634db08
@wrrobin
Minor update reverted to match master
096f92e
@kwaters4
[Annex C] Remove trapped and replace with detect
d1e22fb
@kwaters4
[Appendix D 1.4] Add shmem_my_pe as a standard way to get process ID
e31215b
@kwaters4
[ChangeLog] Add inclusive and exlcusive scan
71aa81a
@BKP
profiler: remove whitespace at end of line
ac51892
@kwaters4
Merge pull request #5 from kwaters4/scan_changelog
61b013f 
[ChangeLog] Add inclusive and exlcusive scan
@wrrobin
Minor text edits
b0e7115
@davidozog
backmatter: Add an "Errata" section w/ 1.5 entries
930bbda
@davidozog
Update content/backmatter.tex
5e3bc96
@davidozog @jdinan
Update content/backmatter.tex
47feb0d 
Co-authored-by: James Dinan <[email protected]>
@davidozog
backmatter: changelogs to enumerate, rm git links
2ae28b4
@davidozog
backmatter: code review errata section corrections
07da7b3
@davidozog
back: Add Errata changelog, reorder for clarity
a0bc82e
@wrrobin
Clarification of query_initialized
25bb62d
@wrrobin
Brian suggestion on init finalize
5596f4f
@maawad
Fix shmem_team_split_strided's start argument wording for non-pos…
3b1cbb3 
…itive value.
@davidozog
teams: split does not permit parent PE wrap-around
1aa5958
@jdinan
DocEdit: Whitespace
82b8e19 
Signed-off-by: James Dinan <[email protected]>
jdinan
jdinan commented Sep 27, 2024
View reviewed changes
content/coverpage.tex
\item Bob Cernohous, \ac{HPE}
\item James Dinan\footnotemark[1], NVIDIA
\item Megan Grodowitz, Arm Inc.
\item Max Grossman, Georgia Tech
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrippa Is this the right institution for you?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @agrippa is currently affiliated with Cruise (https://www.getcruise.com/), but he represented Georgia Tech when he served on the spec committee.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Max, let us know if you want to update your affiliation.

jdinan
jdinan commented Sep 27, 2024
View reviewed changes
content/shmem_team_split_strided.tex
Comment on lines +70 to +72
For example, the list of \acp{PE} in the parent team should not start at a high
number and then continue to include \acp{PE} in the lower end of the parent
team's \ac{PE} range.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wokuno To change to "Given a parent team with XYZ PEs, a call to shmem_team_split strided with the following arguments would be invalid."

jdinan
jdinan commented Sep 27, 2024
View reviewed changes
content/shmem_team_split_strided.tex
@@ -13,8 +13,7 @@
\begin{apiarguments}
\apiargument{IN}{parent\_team}{An \openshmem team.}

\apiargument{IN}{start}{The lowest \ac{PE} number of the subset of \acp{PE} from
the parent team that will form the new team.}
\apiargument{IN}{start}{The first \acs{PE} number of the subset of \acp{PE} from the parent team that will form the new team. If the stride is less than zero, the first \acs{PE} number is the highest \acs{PE} of the parent team; if it is greater than zero, it is the lowest; if the stride is zero, it is the starting \acs{PE}.}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwaters4 To look into improving the clarity of this sentence.

@ahayashi ahayashi mentioned this pull request Sep 27, 2024
Closed
@jdinan jdinan merged commit 4b70f0b into openshmem-org:master Sep 27, 2024
1 check passed
@jdinan
Copy link
Collaborator Author

jdinan commented Sep 27, 2024

All proposed edits merged into #546

@jdinan jdinan mentioned this pull request Sep 27, 2024
Closed
@ahayashi ahayashi mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwaters4 kwaters4 kwaters4 left review comments

@ahayashi ahayashi ahayashi left review comments

Assignees
No one assigned
Labels
HadReading Ratified
Projects
No open projects
OpenSHMEM 1.6 Section Committees
Status: Doc Editor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.