-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Fortran bind(C) support for basic OpenSHMEM routines #257
base: main
Are you sure you want to change the base?
Conversation
all: ${TARGET}.pdf | ||
all: ${TARGET}.pdf ${LANG_EXT}.pdf | ||
|
||
${TARGET}.pdf: ${SOURCES} ${FIGURES} ${EXAMPLES} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: Duplicate ${TARGET}.pdf
rule. Did you mean `${LANG_EXT}.pdf?
\end{center} | ||
|
||
\begin{center} | ||
\textbf{\LARGE Application Programming Interface}\\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this page should be abstracted via \input
or something so all of the acknowledgments, etc. don't desync from the main_spec
document.
@@ -0,0 +1,365 @@ | |||
As the \Fortran[bind(C)] language bindings are implemented over the \openshmem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move all of these files from directory "ftn08" to directory "fortran2008" to more closely match the referred-to named "ISO/IEC 1539-1:2010 (Fortran 2008)". Or "fortran2018", or just "fortran" if you never anticipate ever having two separate sets of FortranXXXX language bindings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nick had a comment that if these bindings are for Fortran 2018 because of its support for AMOs, collectives, etc., this document should make that comment somewhere so that users know why the C_BIND interface for AMOs, collectives are missing.
@@ -0,0 +1,7 @@ | |||
\openshmem provides ISO \Cstd bindings. \Cstd bindings are the primary language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first and second sentences sound redundant. I would drop one of the sentences, or change/reword/reorder them if you were trying to impart specific information.
Should the OpenSHMEM bindings for Fortran specify the relationship between...?
|
As per Issue #249, we are creating a new separate document for adding separate language bindings which are not part of the main OpenSHMEM specification. We have created this separate document for adding Fortran bind(C) language bindings and this can be extended when we need other new language bindings in future.