Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Fortran bind(C) support for basic OpenSHMEM routines #257

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

naveen-rn
Copy link
Contributor

As per Issue #249, we are creating a new separate document for adding separate language bindings which are not part of the main OpenSHMEM specification. We have created this separate document for adding Fortran bind(C) language bindings and this can be extended when we need other new language bindings in future.

@naveen-rn naveen-rn self-assigned this Nov 25, 2018
@naveen-rn naveen-rn removed their assignment Nov 25, 2018
all: ${TARGET}.pdf
all: ${TARGET}.pdf ${LANG_EXT}.pdf

${TARGET}.pdf: ${SOURCES} ${FIGURES} ${EXAMPLES}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Duplicate ${TARGET}.pdf rule. Did you mean `${LANG_EXT}.pdf?

\end{center}

\begin{center}
\textbf{\LARGE Application Programming Interface}\\
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this page should be abstracted via \input or something so all of the acknowledgments, etc. don't desync from the main_spec document.

@@ -0,0 +1,365 @@
As the \Fortran[bind(C)] language bindings are implemented over the \openshmem
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all of these files from directory "ftn08" to directory "fortran2008" to more closely match the referred-to named "ISO/IEC 1539-1:2010 (Fortran 2008)". Or "fortran2018", or just "fortran" if you never anticipate ever having two separate sets of FortranXXXX language bindings.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nick had a comment that if these bindings are for Fortran 2018 because of its support for AMOs, collectives, etc., this document should make that comment somewhere so that users know why the C_BIND interface for AMOs, collectives are missing.

@@ -0,0 +1,7 @@
\openshmem provides ISO \Cstd bindings. \Cstd bindings are the primary language
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first and second sentences sound redundant. I would drop one of the sentences, or change/reword/reorder them if you were trying to impart specific information.

@nspark
Copy link
Contributor

nspark commented May 21, 2019

Should the OpenSHMEM bindings for Fortran specify the relationship between...?

  • shmem_my_pe() and this_image()
  • shmem_n_pes() and num_images()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants