PODAUTO-225: Add olm e2e upgrade test for VPA-operator #56247
Conversation
|
@maxcao13: This pull request references PODAUTO-225 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-release-4.17-ci-bundle-vertical-pod-autoscaler-operator-bundle |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
I think we might need to split this PR up into 2 because I don't think we can promote the bundle using a rehearsal. So I think this PR will be a promotion PR, and then I'll followup with the actual upgrade test when we have the 4.17 bundle available + yamllint. |
|
Depends on: #56306 |
maxcao13
force-pushed
the
vpa-operator-sdk-post-merge
branch
2 times, most recently
from
5a48c7d
to
fcec035
Compare
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-lint |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-sdk-post-merge
branch
2 times, most recently
from
35c2092
to
2e86070
Compare
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-yamllint pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade Put yamllint in its own test using a python ubi image. I also doubt, the upgrade test will work because I don't think the bundle is promoted yet, but who knows. |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-sdk-post-merge
branch
4 times, most recently
from
f920e83
to
e9f19a7
Compare
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade pull-ci-openshift-vertical-pod-autoscaler-operator-master-lint |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Depends on: openshift/vertical-pod-autoscaler-operator#173 |
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-sdk-post-merge
branch
2 times, most recently
from
b3aab30
to
9557367
Compare
maxcao13
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-master-e2e-aws-upgrade |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
maxcao13
force-pushed
the
vpa-operator-sdk-post-merge
branch
from
9557367
to
efc892c
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
I'm really glad to have the new upgrade test. Thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelsmith, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@maxcao13: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* Add olm e2e upgrade test for VPA-operator * Add yamllint to lint test * Add regex to skip certain jobs based on changed files * Fix upgrade test
* Add olm e2e upgrade test for VPA-operator * Add yamllint to lint test * Add regex to skip certain jobs based on changed files * Fix upgrade test
This PR is mostly adapted from WMCO's upgrade suite here:
release/ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
Line 141 in 95e5bb9
Slightly different is that we have to sort of work backwards and add a little bit of operator-sdk compatibility in the 4.17 branch, but luckily there is already a
images/ci/bundle.Dockerfilein there. Most of the other changes can be directly mended in the test config. We also have to promote a 4.17 bundle image in order to use it in 4.18 to upgrade to.