first pass at a code of conduct #1576
Conversation
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
docs/developer/Code_of_Conduct.md
Outdated
|
|
||
| ### Pull Request guidelines | ||
| 1. Follow the PR template instructions. | ||
| 1. Avoid self overrides. If prow tests are failing, ask the reviewers to override tests if needed. |
There was a problem hiding this comment.
Do we also want to address when overrides are appropriate, at least in part? Something like "Always allow a required test to run and fail first before overriding" if we want to make a hard rule there. Otherwise, "Never override unless we expect the test to fail consistently."
There was a problem hiding this comment.
I think we should have the discussion first. Not sure if I'm right, but IMHO I said someone that is currently on the CI team should look at the failure and override. This way we can catch the repeat issues and appropriately add to @mpryc 's retry mechanism. Open for discussion and clarifying
There was a problem hiding this comment.
can we enforce who can override through OWNERS file?
There was a problem hiding this comment.
@mateusoliveira43 The enforcement we're talking about here isn't for users who shouldn't be in OWNERS, though. i.e. if someone who is an owner submits a PR, that person shouldn't override. I guess the real question is whether the prow bot can enforce rules like "don't allow /override from author".
|
@mpryc please review. |
|
@weshayutin your branch I think is way behind oadp-operator master so it was hard for me to create PR against your branch :) Here is patch: |
openshift-ci
bot
added
the
approved
weshayutin
removed
the
do-not-merge/hold
|
current name is better because of https://github.com/openshift/oadp-operator/community (but I think it needs to be in root of in |
|
How we devs work together in PRs sounds more like Contributing.md more so that Code of conduct. Code of conduct is like behavioral rules unrelated to code contributions which should not include PR conventions. https://github.com/opengovernment/opengovernment/blob/master/CONTRIBUTING.md |
|
The content of currend .md is a combination of both. I would suggest splitting into two. Ones for technical guidelines. Contributing.md |
Writing your contributing guidelines
Establishing a code of conduct
|
|
Example of code of conduct which should have zero technical content. |
weshayutin
force-pushed
the
code_of_conduct
branch
from
e216aa9
to
a7519c2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why the changes were made
Scott made me realize that I had not properly socialized my thoughts on overriding prow jobs. So I thought I'd take a moment and write my thoughts on how to conduct ourselves with PR's and Issues.
How to test the changes made
No testing, but open to discussion and evolving changes.