-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODC-7664: Add subscribe form for Knative EventType #14304
Conversation
@vikram-raj: This pull request references ODC-7664 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f45702a
to
ae0d38d
Compare
ae0d38d
to
672f018
Compare
ec268f9
to
48466b9
Compare
@vikram-raj: This pull request references ODC-7664 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I first enter the Subscribe form, neither Form view nor YAML view was selected. After selecting once I am not able to see the issue
- If service is not created then we are showing alert message as "To create a Subscriber, first create a Knative Service from the Add page." but we don't have the direct CTA in add page for service? can we add link or else to string "Knative Service" so that it will redirect the user to proper link
- Schema for spec is not there. Is this fine?
- Download button is not there in YAML view, is this ok?
- I can see more spacing on top and bottom of Configure via, can we remove that? so that it will align to other forms.
Screen.Recording.2024-10-07.at.11.43.54.AM.mov
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
@vikram-raj: This pull request references ODC-7664 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@vikram-raj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label docs-approved |
Story: https://issues.redhat.com/browse/ODC-7664
Descriptions: This PR adds a subscribe form for Knative EventType.
Screenshots:
odc-7664.mov
Test setup: