Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-7664: Add subscribe form for Knative EventType #14304

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Sep 17, 2024

Story: https://issues.redhat.com/browse/ODC-7664

Descriptions: This PR adds a subscribe form for Knative EventType.

Screenshots:

odc-7664.mov

image

Test setup:

  • Install Serverless operator and create Knative Serving and Eventing CR
  • Enable eventtype-auto-create: enabled in ConfigMap config-features present in knative-eventing namespace
  • Create a broker in your namespace kn broker create my-broker
  • Send an event to broker kn event send \ --to Broker:eventing.knative.dev/v1:my-broker\ --type com.corp.integration.warning \ -f message="Hey there my Broker"
  • Navigate to Events catalog from the Event action on the Add page

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2024

@vikram-raj: This pull request references ODC-7664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7664

Descriptions: This PR adds a subscribe form for Knative EventType.

Screenshots:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@openshift-ci openshift-ci bot added component/knative Related to knative-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2024
@vikram-raj vikram-raj changed the title WIP: ODC-7664: Add subscribe form for Knative EventType ODC-7664: Add subscribe form for Knative EventType Sep 26, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2024
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Sep 26, 2024
@vikram-raj vikram-raj force-pushed the odc-7664 branch 6 times, most recently from ec268f9 to 48466b9 Compare October 1, 2024 10:28
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2024

@vikram-raj: This pull request references ODC-7664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7664

Descriptions: This PR adds a subscribe form for Knative EventType.

Screenshots:

odc-7664.mov

image

Test setup:

  • Install Serverless operator and create Knative Serving and Eventing CR
  • Enable eventtype-auto-create: enabled in ConfigMap config-features present in knative-eventing namespace
  • Create a broker in your namespace kn broker create my-broker
  • Send an event to broker kn event send \ --to Broker:eventing.knative.dev/v1:my-broker\ --type com.corp.integration.warning \ -f message="Hey there my Broker"
  • Navigate to Events catalog from the Event action on the Add page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@lokanandaprabhu lokanandaprabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I first enter the Subscribe form, neither Form view nor YAML view was selected. After selecting once I am not able to see the issue
Screenshot 2024-10-07 at 11 35 11 AM
  1. If service is not created then we are showing alert message as "To create a Subscriber, first create a Knative Service from the Add page." but we don't have the direct CTA in add page for service? can we add link or else to string "Knative Service" so that it will redirect the user to proper link
Screenshot 2024-10-07 at 11 37 02 AM
  1. Schema for spec is not there. Is this fine?
Screenshot 2024-10-07 at 11 39 15 AM
  1. Download button is not there in YAML view, is this ok?
Screenshot 2024-10-07 at 11 48 08 AM
  1. I can see more spacing on top and bottom of Configure via, can we remove that? so that it will align to other forms.
Screen.Recording.2024-10-07.at.11.43.54.AM.mov

@lokanandaprabhu
Copy link
Contributor

/retest

@lokanandaprabhu
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@vikram-raj
Copy link
Member Author

/retest

@The-Anton
Copy link
Member

Tested using cluster bot, working fine

/label qe-approved

image

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 9, 2024
@The-Anton
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2024

@vikram-raj: This pull request references ODC-7664 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Story: https://issues.redhat.com/browse/ODC-7664

Descriptions: This PR adds a subscribe form for Knative EventType.

Screenshots:

odc-7664.mov

image

Test setup:

  • Install Serverless operator and create Knative Serving and Eventing CR
  • Enable eventtype-auto-create: enabled in ConfigMap config-features present in knative-eventing namespace
  • Create a broker in your namespace kn broker create my-broker
  • Send an event to broker kn event send \ --to Broker:eventing.knative.dev/v1:my-broker\ --type com.corp.integration.warning \ -f message="Hey there my Broker"
  • Navigate to Events catalog from the Event action on the Add page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vikram-raj
Copy link
Member Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Oct 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 35eca95 into openshift:master Oct 9, 2024
6 checks passed
@vikram-raj vikram-raj deleted the odc-7664 branch October 10, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants