Dockerfile and test for Hub cluster part #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Cardenosa <[email protected]>
natifridman
reviewed
Sep 2, 2024
tests/pytest/ztp-left-shifting/sno-hub/check-hub-installation.py
Outdated
Show resolved
Hide resolved
| {"cmd": f"oc --kubeconfig {kubeconfig} whoami --show-console", "response": 200}, | ||
| {"cmd": f"oc --kubeconfig {kubeconfig} get managedcluster local-cluster -ojsonpath='{{.spec.managedClusterClientConfigs[0].url}}'", "response": 403}, | ||
| ]) | ||
| def test_http_endpoint(bash, endpoint): |
There was a problem hiding this comment.
Maybe it's missing bash fixture?
| {"cmd": f"oc --kubeconfig {kubeconfig} whoami --show-console", "response": 200}, | ||
| {"cmd": f"oc --kubeconfig {kubeconfig} get managedcluster local-cluster -ojsonpath='{{.spec.managedClusterClientConfigs[0].url}}'", "response": 403}, | ||
| ]) | ||
| def test_http_endpoint(bash, endpoint): |
There was a problem hiding this comment.
It's not so clear why you need to use parameterize here.
There was a problem hiding this comment.
As I said before, I just moved the code that was previously in the Openshift-CI step here for a conceptual test. At the moment I'm not that interested in this test being really very comprehensive, just that it works.
When we have the Openshift-CI part integrated, we can come back to this and discuss what tests to run to ensure that the Hub cluster and its components have been correctly installed.
My idea is that, later on, we can adjust the tests to run from eco-ci-cd.
Co-authored-by: Nati Fridman <[email protected]>
|
Thanks for your comments @natifridman |
natifridman
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will be used by Prow to deploy and verify the Hub cluster part.