Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.10] Define knative-serving-ingress for Kourier Gateway xdp client #90

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

nak3
Copy link

@nak3 nak3 commented Jul 14, 2023

This patch is same with #89 but against 1.10.

@openshift-ci openshift-ci bot requested review from ReToCode and skonto July 14, 2023 02:34
@nak3
Copy link
Author

nak3 commented Jul 14, 2023

/cc @ReToCode @skonto

@codecov-commenter
Copy link

Codecov Report

Merging #90 (b5c4b0a) into release-v1.10 (5f7819e) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##           release-v1.10      #90   +/-   ##
==============================================
  Coverage          80.78%   80.78%           
==============================================
  Files                 18       18           
  Lines               1343     1343           
==============================================
  Hits                1085     1085           
  Misses               205      205           
  Partials              53       53           

@nak3
Copy link
Author

nak3 commented Jul 14, 2023

For Verify / verify / Verify Deps and Codegen (pull_request), we need to ignore the error as we(downstream) added the patch under vendor directory. (It will be dropped after 1.11.) Upstream's verify action complains about it.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Author

nak3 commented Jul 14, 2023

/override "Verify / verify / Verify Deps and Codegen"

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2023

@nak3: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Verify / verify / Verify Deps and Codegen

Only the following failed contexts/checkruns were expected:

  • ci/prow/410-images
  • ci/prow/413-images
  • pull-ci-openshift-knative-net-kourier-release-v1.10-410-images
  • pull-ci-openshift-knative-net-kourier-release-v1.10-413-images
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • tide
  • verify / Verify Deps and Codegen

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Verify / verify / Verify Deps and Codegen"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Author

nak3 commented Jul 14, 2023

/override "verify / Verify Deps and Codegen"

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2023

@nak3: Overrode contexts on behalf of nak3: verify / Verify Deps and Codegen

In response to this:

/override "verify / Verify Deps and Codegen"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 915d5f8 into openshift-knative:release-v1.10 Jul 14, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants