Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.14] Add extra kcertificate for kourier #131

Merged

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented May 1, 2024

  • As kourier runs in a separate namespace in OCP we need this certificate additionally
  • In upstream it uses the one in knative-serving created by serving

@ReToCode
Copy link
Member Author

ReToCode commented May 1, 2024

/assign @skonto

@skonto
Copy link

skonto commented May 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 1, 2024
Copy link

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ffd43ac into openshift-knative:release-v1.14 May 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants