Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.10][CVE-2023-44487] SYNC Upstream - update GRPC to 1.56.3 #115

Merged

Conversation

skonto
Copy link

@skonto skonto commented Oct 25, 2023

  • Sync with upstream deps
  • Brings in the grpc fix

knative-automation and others added 2 commits October 25, 2023 12:07
bumping knative.dev/pkg df28fea...0c39ce4:
  > 0c39ce4 Allow to disable http2 for the webhook (# 2877)

Signed-off-by: Knative Automation <[email protected]>
@openshift-ci openshift-ci bot requested review from alanfx and mgencur October 25, 2023 09:10
@skonto skonto requested review from nak3 and ReToCode and removed request for mgencur and alanfx October 25, 2023 09:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ab2c10) 80.78% compared to head (1ae8856) 80.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff               @@
##           release-v1.10     #115   +/-   ##
==============================================
  Coverage          80.78%   80.78%           
==============================================
  Files                 18       18           
  Lines               1343     1343           
==============================================
  Hits                1085     1085           
  Misses               205      205           
  Partials              53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ReToCode
Copy link
Member

/override "Verify / verify / Verify Deps and Codegen"

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Verify / verify / Verify Deps and Codegen

Only the following failed contexts/checkruns were expected:

  • ci/prow/411-images
  • ci/prow/413-images
  • pull-ci-openshift-knative-net-kourier-release-v1.10-411-images
  • pull-ci-openshift-knative-net-kourier-release-v1.10-413-images
  • style / suggester / github_actions
  • style / suggester / yaml
  • tide
  • verify / Verify Deps and Codegen

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Verify / verify / Verify Deps and Codegen"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member

/override "verify / Verify Deps and Codegen"

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

@ReToCode: Overrode contexts on behalf of ReToCode: verify / Verify Deps and Codegen

In response to this:

/override "verify / Verify Deps and Codegen"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 81663fe into openshift-knative:release-v1.10 Oct 25, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants