[RELEASE-1.10][CVE-2023-44487] Update GRPC to 1.58.3 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skonto
commented
Oct 24, 2023
skonto
commented
- Similar to [RELEASE-1.9][CVE-2023-44487] Update GRPC to 1.58.3 #109
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Verify fails because we dont apply the patches when comparing. |
ReToCode
reviewed
Oct 25, 2023
| @@ -104,3 +107,5 @@ require ( | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | |||
| sigs.k8s.io/yaml v1.3.0 // indirect | |||
| ) | |||
|
|
|||
| replace google.golang.org/grpc => google.golang.org/grpc v1.58.3 | |||
There was a problem hiding this comment.
Same here, lets only go to 1.56.3 to avoid a too big difference to upstream (which has been used in the wild) and not introduce a unnecessary risk of side-effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.