[release-v1.10] Sync upstream release #106
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
We do not want that change in our fork: https://github.com/openshift-knative/net-kourier/actions/runs/6492840467/job/17632564714?pr=106 /override "verify / Verify Deps and Codegen" |
|
@ReToCode: Overrode contexts on behalf of ReToCode: verify / Verify Deps and Codegen In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| knative.dev/networking v0.0.0-20230419144338-e5d04e805e50 | ||
| knative.dev/pkg v0.0.0-20230418073056-dfad48eaa5d0 | ||
| knative.dev/networking v0.0.0-20231012063223-0b0f2107abef | ||
| knative.dev/pkg v0.0.0-20231011201526-df28feae6d34 |
There was a problem hiding this comment.
This contains the fix right? Same for networking?
There was a problem hiding this comment.
Yes, networking 1.10 commit is https://github.com/knative/networking/commits/release-1.10 (0b0f2107abefcf776c72e1325678f0a33b9b45ef)
|
@ReToCode do you know why #106 (comment) was not required for net-istio? Changes in vendor/knative.dev/pkg/environment/client_config.go were not propagated to net-istio 1.10? |
AFAIK, I don't think we have the changes in net-istio at all. As what we have in net-kourier is a patch we added, right? Maybe we are missing a git patch for those changes here, so that the diff occurs at all? our net-istio is like upstream net-istio: https://github.com/openshift-knative/net-istio/blob/release-v1.10/vendor/knative.dev/pkg/environment/client_config.go#L45 |
|
We do have the patch, maybe it is not applied in that verify script in this branch somehow? No idea, but we do not want the upstream version, so should be fine? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: github-actions[bot], skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Correct it is not applied I am wondering if istio has such patch. It seems it was not udpated: https://github.com/openshift-knative/net-istio/blob/release-v1.10/vendor/knative.dev/pkg/environment/client_config.go |
Sync upstream release