Upstream create-release-branch.sh to use correct branch
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nak3
changed the title
create-release-branch.sh to use correct versioncreate-release-branch.sh to use correct version
nak3
changed the title
create-release-branch.sh to use correct versioncreate-release-branch.sh to use correct branch
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 1c13440
into
openshift-knative:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is same with openshift-knative/net-kourier#92
There are two changes in this PR.
Recently we added
vprefix for downstream branch but upstream does not have it.Hence, we need the following line:
upstream_release=release-${release#"release-v"}Also, the downstream's version label is equal to branch name so it should be:
openshift/release/download_release_artifacts.sh ${release}