Generate Konflux configurations #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierDipi
force-pushed
the
konflux-gen
branch
3 times, most recently
from
e37dbe1
to
f246093
Compare
Integrate KonfluxGen with prowgen so that after running prowgen we can create PRs for all midstream repositories to add/update/remove Konflux components and applications (to be added pipelines and ImageRepository). Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
changed the title
|
LGTM. |
|
I would merge and try it ! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7515806
into
openshift-knative:main
5 checks passed
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate KonfluxGen with prowgen so that after running prowgen we can create PRs for all midstream repositories to add/update/remove Konflux components and applications (to be added pipelines in
.tekton).The idea is:
konflux: enabled: trueTo create PRs we need to generate one step per repository per branch and so there is a new command
make update-actionand the consistency is verified as part of themake unit-testscommand