Skip to content

Commit

Permalink
Skip hermetic Dockerfiles in prowgen image discovery (#306)
Browse files Browse the repository at this point in the history
Signed-off-by: Pierangelo Di Pilato <[email protected]>
  • Loading branch information
pierDipi authored Oct 1, 2024
1 parent 141a787 commit d744cbc
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
4 changes: 4 additions & 0 deletions config/eventing-kafka-broker.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
config:
branches:
release-next:
skipDockerFilesMatches:
- .*hermetic.*
konflux:
javaImages:
- .*eventing-kafka-broker-receiver
Expand Down Expand Up @@ -35,6 +37,8 @@ config:
- onDemand: true
version: "4.13"
release-v1.15:
skipDockerFilesMatches:
- .*hermetic.*
konflux:
enabled: true
openShiftVersions:
Expand Down
10 changes: 10 additions & 0 deletions pkg/prowgen/prowgen_images_discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ func discoverDockerfiles(r Repository, skipDockerFiles []string) ([]string, erro
if len(r.Dockerfiles.Matches) != 0 {
dockerFilesToInclude = r.Dockerfiles.Matches
}
skips := make([]*regexp.Regexp, 0, len(skipDockerFiles))
for _, dockerfile := range skipDockerFiles {
skips = append(skips, regexp.MustCompile(dockerfile))
}

filteredDockerFiles := slices.Filter(nil, dockerFilesToInclude, func(s string) bool {
return !slices.Contains(skipDockerFiles, s)
})
Expand All @@ -132,6 +137,11 @@ func discoverDockerfiles(r Repository, skipDockerFiles []string) ([]string, erro
if !include {
return nil
}
for _, s := range skips {
if s.MatchString(path) {
return nil
}
}
dockerfiles.Insert(filepath.Join(rootDir, path))
return nil
})
Expand Down

0 comments on commit d744cbc

Please sign in to comment.