Skip to content

Commit

Permalink
Per application RPA
Browse files Browse the repository at this point in the history
the RPA has the filename that is not application name dependent, so
new applications will override the existing ones rather than creating
new ones, so that we can just take them as they are and commit to
"`releng`".

Remove `v` prefix from tags.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
  • Loading branch information
pierDipi committed Oct 14, 2024
1 parent a0e0ae6 commit bbc7623
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,4 @@ spec:
tags:
- "{{ git_sha }}"
- "{{ git_short_sha }}"
- "v1.35.0"
- "1.35.0"
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,4 @@ spec:
tags:
- "{{ git_sha }}"
- "{{ git_short_sha }}"
- "v1.35.0"
- "1.35.0"
4 changes: 2 additions & 2 deletions pkg/konfluxgen/konfluxgen.go
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ func GenerateReleasePlanAdmission(csvPath string, resourceOutputPath string, app
if err := os.MkdirAll(outputDir, 0777); err != nil {
return fmt.Errorf("failed to create release plan admissions directory: %w", err)
}
outputFilePath := filepath.Join(outputDir, "prod.yaml")
outputFilePath := filepath.Join(outputDir, fmt.Sprintf("%s-prod.yaml", Truncate(Sanitize(appName))))

components, err := getComponentImageRefs(csv)
if err != nil {
Expand All @@ -739,7 +739,7 @@ func GenerateReleasePlanAdmission(csvPath string, resourceOutputPath string, app
})
}

outputFilePath = filepath.Join(outputDir, "stage.yaml")
outputFilePath = filepath.Join(outputDir, fmt.Sprintf("%s-stage.yaml", Truncate(Sanitize(appName))))
if err := executeReleasePlanAdmissionTemplate(componentWithStageRepoRef, outputFilePath, appName, soVersion); err != nil {
return fmt.Errorf("failed to execute release plan admission template: %w", err)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/konfluxgen/releaseplanadmission.template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ spec:
tags:
- "{{ git_sha }}"
- "{{ git_short_sha }}"
- "v{{{ .Version }}}"
- "{{{ .Version }}}"

0 comments on commit bbc7623

Please sign in to comment.