Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #85

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix tests #85

merged 3 commits into from
Apr 2, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Mar 28, 2024

As per title

  • Pin AMQ version, change Kafka version
  • Fix SO index image

It's a draft since I don't want to run the tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Copy link

openshift-ci bot commented Mar 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Makefile Outdated
Comment on lines 7 to 12

test-kafka-broker-namespaced-upstream-nightly:
./bin/test-kafka-broker-namespaced-upstream-nightly.sh || exit 1

test-kafka-broker-namespaced-midstream-nightly:
./bin/test-kafka-broker-namespaced-midstream-nightly.sh || exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi can we remove these test-kafka-broker-namespaced-xyz-nightly.sh files since we are no longer calling them here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Done

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with this repo, but from what I can see LGTM!

Copy link

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/test ?

Copy link

openshift-ci bot commented Mar 29, 2024

@pierDipi: The following commands are available to trigger required jobs:

  • /test 415-images
  • /test 415-test-kafka-broker-namesp-8045b51-aws-415
  • /test 415-test-kafka-broker-upstre-fbbddbf-aws-415
  • /test 416-images
  • /test 416-test-kafka-broker-namesp-8045b51-aws-416
  • /test 416-test-kafka-broker-upstre-fbbddbf-aws-416

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-knative-eventing-hyperfoil-benchmark-main-415-images
  • pull-ci-openshift-knative-eventing-hyperfoil-benchmark-main-415-test-kafka-broker-upstre-fbbddbf-aws-415
  • pull-ci-openshift-knative-eventing-hyperfoil-benchmark-main-416-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

/test 415-images
/test 416-images

@pierDipi
Copy link
Member Author

pierDipi commented Apr 2, 2024

/retest-required

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi pierDipi marked this pull request as ready for review April 2, 2024 11:47
@openshift-ci openshift-ci bot requested review from lberk and matzew April 2, 2024 11:48
Copy link

openshift-ci bot commented Apr 2, 2024

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-images 18c45ec link true /test 416-images
ci/prow/415-images 2fff986 link true /test 415-images
ci/prow/414-images 2fff986 link true /test 414-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi pierDipi merged commit feba224 into openshift-knative:main Apr 2, 2024
1 of 4 checks passed
@pierDipi pierDipi deleted the fix-tests branch April 2, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants