-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #85
Fix tests #85
Conversation
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Skipping CI for Draft Pull Request. |
Makefile
Outdated
|
||
test-kafka-broker-namespaced-upstream-nightly: | ||
./bin/test-kafka-broker-namespaced-upstream-nightly.sh || exit 1 | ||
|
||
test-kafka-broker-namespaced-midstream-nightly: | ||
./bin/test-kafka-broker-namespaced-midstream-nightly.sh || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierDipi can we remove these test-kafka-broker-namespaced-xyz-nightly.sh
files since we are no longer calling them here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Done
Signed-off-by: Pierangelo Di Pilato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with this repo, but from what I can see LGTM!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@pierDipi: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test 415-images |
/retest-required |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
As per title
It's a draft since I don't want to run the tests